Action feed - final patch

Review Request #3292 — Created Aug. 19, 2012 and discarded

bogdana
Review Board
reviewboard
This patch contains all the changes added for this feature, including updates to r/3151, r/3260 and r/3272.
Ran manage.py test.
Description From Last Updated

Col: 40 E121 continuation line indentation is not a multiple of four

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 13 E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Col: 17 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 17 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 17 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 17 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 17 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 13 E124 closing bracket does not match visual indentation

reviewbotreviewbot

Col: 68 W292 no newline at end of file

reviewbotreviewbot

Col: 42 E121 continuation line indentation is not a multiple of four

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 31 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 19 E221 multiple spaces before operator

reviewbotreviewbot

Col: 20 E221 multiple spaces before operator

reviewbotreviewbot

Col: 21 E221 multiple spaces before operator

reviewbotreviewbot

Col: 21 E221 multiple spaces before operator

reviewbotreviewbot

Col: 20 E221 multiple spaces before operator

reviewbotreviewbot

Col: 80 E501 line too long (80 > 79 characters)

reviewbotreviewbot

Col: 36 W292 no newline at end of file

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 6 E121 continuation line indentation is not a multiple of four

reviewbotreviewbot

Col: 9 E121 continuation line indentation is not a multiple of four

reviewbotreviewbot

Col: 9 E121 continuation line indentation is not a multiple of four

reviewbotreviewbot

Col: 9 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 9 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 9 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 9 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 9 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 9 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 9 E124 closing bracket does not match visual indentation

reviewbotreviewbot

Col: 68 W292 no newline at end of file

reviewbotreviewbot

Col: 25 E241 multiple spaces after ','

reviewbotreviewbot

Col: 26 E241 multiple spaces after ','

reviewbotreviewbot

Col: 27 E241 multiple spaces after ','

reviewbotreviewbot

Col: 27 E241 multiple spaces after ','

reviewbotreviewbot

Col: 26 E241 multiple spaces after ','

reviewbotreviewbot

Col: 5 E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

Col: 80 E501 line too long (90 > 79 characters)

reviewbotreviewbot

Col: 80 E501 line too long (85 > 79 characters)

reviewbotreviewbot

Col: 5 E304 blank lines found after function decorator

reviewbotreviewbot

Col: 21 E128 continuation line under-indented for visual indent

reviewbotreviewbot

Col: 80 E501 line too long (83 > 79 characters)

reviewbotreviewbot

Col: 16 E225 missing whitespace around operator

reviewbotreviewbot

Col: 17 E124 closing bracket does not match visual indentation

reviewbotreviewbot
chipx86
  1. Hey,
    
    Sorry to leave you hanging on this. Trying to get a bunch of other work off my plate now that the holidays are over.
    
    We're going to turn around a faster 1.8, and I'd like this to be one of the starring features in it. So I'll be giving you a review of this pretty soon and working to get it in.
    
    Feel free to come bug me in IRC, too, if I'm dragging my feet on it :)
    1. Perfect timing! :) 
      I was just working on updating things to the current changes. Will post a new diff very soon.
  2. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/settings.py
        reviewboard/webapi/resources.py
        reviewboard/reviews/models.py
        reviewboard/reviews/datagrids.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/management/commands/rb-cleanup.py
      Ignored Files:
        reviewboard/static/rb/js/action-feed.js
        docs/manual/webapi/2.0/resources/action-list.txt
        docs/manual/webapi/2.0/resources/index.txt
        reviewboard/static/rb/js/datastore.js
        reviewboard/templates/reviews/dashboard.html
        docs/manual/webapi/2.0/resources/action.txt
        reviewboard/static/rb/css/action-feed.less
    
    
    WARNING: Number of comments exceeded maximum, showing 30 of 37.
    1. We're testing ReviewBot, and some of these errors don't really apply. Ignore the ones that say multiples of 4, for instance.
      
      Mainly, ignore E121.
  2. reviewboard/reviews/admin.py (Diff revision 2)
     
     
    Col: 40
     E121 continuation line indentation is not a multiple of four
    
  3. reviewboard/reviews/admin.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. Col: 13
     E126 continuation line over-indented for hanging indent
    
  5. Col: 17
     E128 continuation line under-indented for visual indent
    
  6. Col: 17
     E128 continuation line under-indented for visual indent
    
  7. Col: 17
     E128 continuation line under-indented for visual indent
    
  8. Col: 17
     E128 continuation line under-indented for visual indent
    
  9. Col: 17
     E128 continuation line under-indented for visual indent
    
  10. Col: 13
     E124 closing bracket does not match visual indentation
    
  11. Col: 68
     W292 no newline at end of file
    
  12. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 42
     E121 continuation line indentation is not a multiple of four
    
  13. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  14. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  15. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  16. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  17. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  18. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  19. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 31
     E128 continuation line under-indented for visual indent
    
  20. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  21. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 19
     E221 multiple spaces before operator
    
  22. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 20
     E221 multiple spaces before operator
    
  23. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 21
     E221 multiple spaces before operator
    
  24. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 21
     E221 multiple spaces before operator
    
  25. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 20
     E221 multiple spaces before operator
    
  26. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 80
     E501 line too long (80 > 79 characters)
    
  27. reviewboard/reviews/models.py (Diff revision 2)
     
     
    Col: 36
     W292 no newline at end of file
    
  28. reviewboard/reviews/views.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  29. reviewboard/settings.py (Diff revision 2)
     
     
    Col: 6
     E121 continuation line indentation is not a multiple of four
    
  30. reviewboard/settings.py (Diff revision 2)
     
     
    Col: 9
     E121 continuation line indentation is not a multiple of four
    
  31. reviewboard/settings.py (Diff revision 2)
     
     
    Col: 9
     E121 continuation line indentation is not a multiple of four
    
  32. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/settings.py
        reviewboard/webapi/resources.py
        reviewboard/reviews/models.py
        reviewboard/reviews/datagrids.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/management/commands/rb-cleanup.py
      Ignored Files:
        reviewboard/static/rb/js/action-feed.js
        docs/manual/webapi/2.0/resources/action-list.txt
        docs/manual/webapi/2.0/resources/index.txt
        reviewboard/static/rb/js/datastore.js
        reviewboard/templates/reviews/dashboard.html
        docs/manual/webapi/2.0/resources/action.txt
        reviewboard/static/rb/css/action-feed.less
    
    
  2. Col: 9
     E128 continuation line under-indented for visual indent
    
  3. Col: 9
     E128 continuation line under-indented for visual indent
    
  4. Col: 9
     E128 continuation line under-indented for visual indent
    
  5. Col: 9
     E128 continuation line under-indented for visual indent
    
  6. Col: 9
     E128 continuation line under-indented for visual indent
    
  7. Col: 9
     E128 continuation line under-indented for visual indent
    
  8. Col: 9
     E124 closing bracket does not match visual indentation
    
  9. Col: 68
     W292 no newline at end of file
    
  10. reviewboard/reviews/models.py (Diff revision 3)
     
     
    Col: 25
     E241 multiple spaces after ','
    
  11. reviewboard/reviews/models.py (Diff revision 3)
     
     
    Col: 26
     E241 multiple spaces after ','
    
  12. reviewboard/reviews/models.py (Diff revision 3)
     
     
    Col: 27
     E241 multiple spaces after ','
    
  13. reviewboard/reviews/models.py (Diff revision 3)
     
     
    Col: 27
     E241 multiple spaces after ','
    
  14. reviewboard/reviews/models.py (Diff revision 3)
     
     
    Col: 26
     E241 multiple spaces after ','
    
  15. reviewboard/settings.py (Diff revision 3)
     
     
    Col: 5
     E123 closing bracket does not match indentation of opening bracket's line
    
  16. reviewboard/webapi/resources.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (90 > 79 characters)
    
  17. reviewboard/webapi/resources.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (85 > 79 characters)
    
  18. reviewboard/webapi/resources.py (Diff revision 3)
     
     
    Col: 5
     E304 blank lines found after function decorator
    
  19. reviewboard/webapi/resources.py (Diff revision 3)
     
     
    Col: 21
     E128 continuation line under-indented for visual indent
    
  20. reviewboard/webapi/resources.py (Diff revision 3)
     
     
    Col: 80
     E501 line too long (83 > 79 characters)
    
  21. reviewboard/webapi/resources.py (Diff revision 3)
     
     
    Col: 16
     E225 missing whitespace around operator
    
  22. 
      
reviewbot
  1. This is a review from Review Bot.
      Tool: PEP8 Style Checker
      Processed Files:
        reviewboard/reviews/views.py
        reviewboard/settings.py
        reviewboard/webapi/resources.py
        reviewboard/reviews/models.py
        reviewboard/reviews/datagrids.py
        reviewboard/reviews/admin.py
        reviewboard/reviews/templatetags/reviewtags.py
        reviewboard/reviews/managers.py
        reviewboard/reviews/management/commands/rb-cleanup.py
      Ignored Files:
        reviewboard/static/rb/js/action-feed.js
        docs/manual/webapi/2.0/resources/action-list.txt
        docs/manual/webapi/2.0/resources/index.txt
        reviewboard/static/rb/js/datastore.js
        reviewboard/templates/reviews/dashboard.html
        docs/manual/webapi/2.0/resources/action.txt
        reviewboard/static/rb/css/action-feed.less
    
    
  2. Col: 17
     E124 closing bracket does not match visual indentation
    
  3. 
      
Review request changed

Status: Discarded

Loading...