Summary

Action feed - final patch

Review Request #3292 — Created Aug. 19, 2012 and discarded July 11, 2014, 4:51 p.m.

Information

Owner

bogdana

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This patch contains all the changes added for this feature, including updates to r/3151, r/3260 and r/3272.

Testing Done

Ran manage.py test.

Issues

Description	From	Last Updated
Col: 40 E121 continuation line indentation is not a multiple of four	reviewbot	Jan. 7, 2013, 12:09 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 13 E126 continuation line over-indented for hanging indent	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 17 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:09 a.m.
Col: 13 E124 closing bracket does not match visual indentation	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 68 W292 no newline at end of file	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 42 E121 continuation line indentation is not a multiple of four	reviewbot	Jan. 7, 2013, 12:10 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 15, 2013, 10:48 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 31 E128 continuation line under-indented for visual indent	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 19 E221 multiple spaces before operator	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 20 E221 multiple spaces before operator	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 21 E221 multiple spaces before operator	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 21 E221 multiple spaces before operator	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 20 E221 multiple spaces before operator	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 36 W292 no newline at end of file	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 8, 2013, 4:10 a.m.
Col: 6 E121 continuation line indentation is not a multiple of four	reviewbot	Jan. 7, 2013, 12:10 a.m.
Col: 9 E121 continuation line indentation is not a multiple of four	reviewbot	Jan. 7, 2013, 12:10 a.m.
Col: 9 E121 continuation line indentation is not a multiple of four	reviewbot	Jan. 7, 2013, 12:10 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:39 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:39 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 9 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 9 E124 closing bracket does not match visual indentation	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 68 W292 no newline at end of file	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 25 E241 multiple spaces after ','	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 26 E241 multiple spaces after ','	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 27 E241 multiple spaces after ','	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 27 E241 multiple spaces after ','	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 26 E241 multiple spaces after ','	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 5 E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 80 E501 line too long (90 > 79 characters)	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 5 E304 blank lines found after function decorator	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 21 E128 continuation line under-indented for visual indent	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 16 E225 missing whitespace around operator	reviewbot	Jan. 10, 2013, 9:40 a.m.
Col: 17 E124 closing bracket does not match visual indentation	reviewbot	Jan. 10, 2013, 9:40 a.m.

Hey,

Sorry to leave you hanging on this. Trying to get a bunch of other work off my plate now that the holidays are over.

We're going to turn around a faster 1.8, and I'd like this to be one of the starring features in it. So I'll be giving you a review of this pretty soon and working to get it in.

Feel free to come bug me in IRC, too, if I'm dragging my feet on it :)

bogdana Jan. 6, 2013, 3:58 a.m.

Perfect timing! :) 
I was just working on updating things to the current changes. Will post a new diff very soon.

Change Summary:

Brought patch up to date with the latest changes in the codebase. 
Decided to split up tests, which will follow in a separate request.

Testing Done:

~		Added extra unit tests.
	~	Ran manage.py test.
-		Ran manage.py test.

Diff:

Revision 2 (+1113 -14)

Show changes

	docs/manual/webapi/2.0/resources/action.txt
	docs/manual/webapi/2.0/resources/action-list.txt
	docs/manual/webapi/2.0/resources/index.txt
	reviewboard/settings.py
	reviewboard/reviews/admin.py
	reviewboard/reviews/datagrids.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models.py
	8 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
    reviewboard/reviews/datagrids.py
    reviewboard/reviews/admin.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/management/commands/rb-cleanup.py
  Ignored Files:
    reviewboard/static/rb/js/action-feed.js
    docs/manual/webapi/2.0/resources/action-list.txt
    docs/manual/webapi/2.0/resources/index.txt
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/dashboard.html
    docs/manual/webapi/2.0/resources/action.txt
    reviewboard/static/rb/css/action-feed.less


WARNING: Number of comments exceeded maximum, showing 30 of 37.

chipx86 Jan. 6, 2013, 7:07 p.m.

We're testing ReviewBot, and some of these errors don't really apply. Ignore the ones that say multiples of 4, for instance.

Mainly, ignore E121.

reviewboard/reviews/admin.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 40
 E121 continuation line indentation is not a multiple of four
```
reviewboard/reviews/admin.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 13
 E126 continuation line over-indented for hanging indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 17
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 13
 E124 closing bracket does not match visual indentation
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 68
 W292 no newline at end of file
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 42
 E121 continuation line indentation is not a multiple of four
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 31
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 19
 E221 multiple spaces before operator
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 20
 E221 multiple spaces before operator
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 21
 E221 multiple spaces before operator
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 21
 E221 multiple spaces before operator
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 20
 E221 multiple spaces before operator
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 36
 W292 no newline at end of file
```
reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 6
 E121 continuation line indentation is not a multiple of four
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 E121 continuation line indentation is not a multiple of four
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 E121 continuation line indentation is not a multiple of four
```

Change Summary:

Style improvements.

Diff:

Revision 3 (+1116 -14)

Show changes

	docs/manual/webapi/2.0/resources/action.txt
	docs/manual/webapi/2.0/resources/action-list.txt
	docs/manual/webapi/2.0/resources/index.txt
	reviewboard/settings.py
	reviewboard/reviews/admin.py
	reviewboard/reviews/datagrids.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models.py
	8 more

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
    reviewboard/reviews/datagrids.py
    reviewboard/reviews/admin.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/management/commands/rb-cleanup.py
  Ignored Files:
    reviewboard/static/rb/js/action-feed.js
    docs/manual/webapi/2.0/resources/action-list.txt
    docs/manual/webapi/2.0/resources/index.txt
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/dashboard.html
    docs/manual/webapi/2.0/resources/action.txt
    reviewboard/static/rb/css/action-feed.less

reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E128 continuation line under-indented for visual indent
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E124 closing bracket does not match visual indentation
```
reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 68
 W292 no newline at end of file
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 25
 E241 multiple spaces after ','
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 26
 E241 multiple spaces after ','
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 27
 E241 multiple spaces after ','
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 27
 E241 multiple spaces after ','
```
reviewboard/reviews/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 26
 E241 multiple spaces after ','
```

reviewboard/settings.py (Diff revision 3)

The issue has been dropped. Show all issues

Col: 5
 E123 closing bracket does not match indentation of opening bracket's line

reviewboard/webapi/resources.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (90 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (85 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E304 blank lines found after function decorator
```
reviewboard/webapi/resources.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 21
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 16
 E225 missing whitespace around operator
```

Change Summary:

More style fixes (gotta catch'em all!)

Diff:

Revision 4 (+1120 -14)

Show changes

	docs/manual/webapi/2.0/resources/action.txt
	docs/manual/webapi/2.0/resources/action-list.txt
	docs/manual/webapi/2.0/resources/index.txt
	reviewboard/settings.py
	reviewboard/reviews/admin.py
	reviewboard/reviews/datagrids.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/models.py
	8 more

Fix it!

This is a review from Review Bot.
  Tool: PEP8 Style Checker
  Processed Files:
    reviewboard/reviews/views.py
    reviewboard/settings.py
    reviewboard/webapi/resources.py
    reviewboard/reviews/models.py
    reviewboard/reviews/datagrids.py
    reviewboard/reviews/admin.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/managers.py
    reviewboard/reviews/management/commands/rb-cleanup.py
  Ignored Files:
    reviewboard/static/rb/js/action-feed.js
    docs/manual/webapi/2.0/resources/action-list.txt
    docs/manual/webapi/2.0/resources/index.txt
    reviewboard/static/rb/js/datastore.js
    reviewboard/templates/reviews/dashboard.html
    docs/manual/webapi/2.0/resources/action.txt
    reviewboard/static/rb/css/action-feed.less

reviewboard/reviews/management/commands/rb-cleanup.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 17
 E124 closing bracket does not match visual indentation
```

Status:: Discarded