-
-
-
-
reviewboard/reviews/datagrids.py (Diff revision 1) I know some older classes don't do this right, but this should be: super(Column, self).__init__(_('Bugs'), ...)
-
-
reviewboard/reviews/datagrids.py (Diff revision 1) You can actually simplify this with the very neat Python generators: return ','.join([ '<a href="%s">%s</a>' % (bug_url % bug, url) for bug in bugs ])
-
reviewboard/reviews/datagrids.py (Diff revision 1) This should include the format, and ideally say "... when rendering bugs column". So: logging.warning('Invalid bug tracker format when rendering bugs column: %s' % bug_url)
-
Dashboard bugs column as clickable links to bug tracker system (if defined)
Review Request #3275 — Created Aug. 13, 2012 and discarded
Information | |
---|---|
tchong | |
Review Board | |
main | |
2589 | |
Reviewers | |
reviewboard | |
Makes the bug numbers into clickable links if a bug tracker system is associated with the review.
Tested on local environment with and without a bug tracker template.
Description | From | Last Updated |
---|---|---|
Imports must be alphabetized. |
|
|
Two blank lines between classes. |
|
|
I know some older classes don't do this right, but this should be: super(Column, self).__init__(_('Bugs'), ...) |
|
|
No space before ':' |
|
|
You can actually simplify this with the very neat Python generators: return ','.join([ '%s' % (bug_url % bug, url) for … |
|
|
This should include the format, and ideally say "... when rendering bugs column". So: logging.warning('Invalid bug tracker format when rendering … |
|
|
Two blank lines. |
|
|
Alignment issues. Make sure you're not using tabs in any code. It should always be 4 space indentation. |
|
|
No need for the \, since it's in parens. |
|
|
We can just unconditionally return this at the end. No need to do it once in the exception handler and … |
|
|
Can you make the = align with the other columns? |
|
|
Alignment issue. |
|
|
Probably should be ", ", actually. A space will make it look nicer, and will allow it to wrap if … |
|
|
Blank line between these. |
|
-
-
reviewboard/reviews/datagrids.py (Diff revision 2) Alignment issues. Make sure you're not using tabs in any code. It should always be 4 space indentation.
-
-
reviewboard/reviews/datagrids.py (Diff revision 2) We can just unconditionally return this at the end. No need to do it once in the exception handler and once in the else statement.
-
-
This looks good in general, but one thing I'd like to see is the links become blue and underlined in the dashboard, so it's clear they're clickable. You can have a class for the column and use that to key off the CSS.
-
-
reviewboard/reviews/datagrids.py (Diff revision 3) Probably should be ", ", actually. A space will make it look nicer, and will allow it to wrap if there's a large number of bugs.
-