Factor out common parts of ReviewRequest and ReviewRequestDraft.
Review Request #3265 — Created Aug. 9, 2012 and submitted
Factor out common parts of ReviewRequest and ReviewRequestDraft. ReviewRequest and ReviewRequestDraft have always had many fields and methods that operated the same way but were defined separately. This has led to a lot of duplicate code, which has always been a pain to keep updated. Now these common fields and methods have been split out into a new base class, BaseReviewRequestDetails. This covers the summary, description, testing done, bugs closed, branch, field normalization during save, human-readable bug list, screenshot/file attachment accessors, default reviewers, and updating from a changenum.
General playing around with the review requests seems to work. All unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
Why not use bugs.sort(key=int)? |
ME medanat |
ME
-
-
reviewboard/reviews/models.py (Diff revision 2) Is it possible to have numbers of type <int> in the bugs list? ie: [1, 2], rather than: ["1", "2"] If not, why not use bugs.sort(key=str.lower) here to make it case insensitive. Just a suggestion.
-
reviewboard/reviews/models.py (Diff revision 2) Is it possible to have numbers of type <int> in the bugs list? ie: [1, 2], rather than: ["1", "2"] If not, why not use bugs.sort(key=str.lower) here to make it case insensitive. Just a suggestion.
