'Load more' functionality for the action feed

Review Request #3260 - Created Aug. 3, 2012 and discarded

Bogdana Popa
Review Board
reviewboard
This patch is built on top of the one in r/3151/
Changes include:
   * generating the action feed by getting the action list via ajax. 
   * brand new "Load more" button


  • 0
  • 0
  • 14
  • 2
  • 16
Description From Last Updated
Christian Hammond
  1. 
      
  2. reviewboard/reviews/models.py (Diff revision 1)
     
     
     
     
    I *think* you can just do:
    
    display_verb = property(get_verb_display)
    
    Might be nice to just add a simple comment saying that get_verb_display is provided automatically .by the verb field. I was confused at first as to where this came from.
    1. I tried writing it as you suggested, but got a syntax error. 
      Added the comment.
  3. reviewboard/static/rb/css/action-feed.less (Diff revision 1)
     
     
     
     
     
     
     
    Ideally, should be alphabetized. We're not always good at this, but for new code, yeah :)
  4. reviewboard/static/rb/js/action-feed.js (Diff revision 1)
     
     
     
     
     
    Really, this should be:
    
    changeitem
        .append(' changed from ')
        .append($('<i/>').text(oldValue)
        ...
        ...;
  5. reviewboard/static/rb/js/action-feed.js (Diff revision 1)
     
     
     
     
    One per line.
  6. reviewboard/static/rb/js/action-feed.js (Diff revision 1)
     
     
     
    The ) should be on the previous line.
  7. reviewboard/static/rb/js/action-feed.js (Diff revision 1)
     
     
     
     
     
    I think these could just go inline when building the div below.
  8. reviewboard/static/rb/js/action-feed.js (Diff revision 1)
     
     
    This should be more clear as to what we're loading. Should mention actions.
  9. reviewboard/static/rb/js/action-feed.js (Diff revision 1)
     
     
    Space before {
  10. reviewboard/static/rb/js/datastore.js (Diff revision 1)
     
     
     
     
     
    Remove these blank lines.
  11. reviewboard/static/rb/js/datastore.js (Diff revision 1)
     
     
    Probably want to remove that.
  12. <input .. />. No end tag.
  13. reviewboard/webapi/resources.py (Diff revision 1)
     
     
     
     
     
    Can we just get this from the review request we link to? I don't know that exposing this is right.
    1. Doesn't the ReviewRequestResource send the actual id of the request and not the local-site one (in case there is a local site)?
      
  14. reviewboard/webapi/resources.py (Diff revision 1)
     
     
     
     
     
    How necessary is this? It'd be nice to use the linked resource instead.
  15. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    "change description"
  16. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    "Human-readable"
  17. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    Rather than basing it on a last ID like this, it might be better to allow searching by a time range. Preferably, we shouldn't be passing around IDs much.
  18. 
      
Bogdana Popa
  1. All issues fixed in Review:3292.
  2. 
      
Bogdana Popa
Review request changed

Status: Discarded

Loading...