Added "Show changes" links to interdiffs in changedesc blobs.

Review Request #3225 — Created July 18, 2012 and submitted

david
Review Board
master
reviewboard
Added "Show changes" links to interdiffs in changedesc blobs.

When a user uploads a diff, we show a link to the uploaded diff revision. We
should also provide a linke to the interdiff, since that's what a lot of people
will want to see.

This is based on Curtis miller's change http://reviews.reviewboard.org/r/2810/
I've updated it to fix the remaining issues, and tweaked the text a little bit
("Show changes" instead of "Show changes").
Published a few versions of a diff and verified that the new link showed
what I expected to.
Description From Last Updated

We shouldn't need this anymore. See below.

chipx86chipx86

We already have a list of diffsets. Rather than do this and the above (which will just add more SQL …

chipx86chipx86

Curtis

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/reviews/views.py (Diff revision 1)
     
     
     
    We shouldn't need this anymore. See below.
  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
     
    We already have a list of diffsets. Rather than do this and the above (which will just add more SQL complexity), we should use the 'diffsets' variable.
    
    Instead of a query, we should just loop through the diffsets (or loop through once above and build a map we can use) to get this value.
  4. 
      
david
chipx86
  1. 
      
  2. AUTHORS (Diff revision 2)
     
     
  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (66a6f70).
Loading...