Allows to view Diff UI with ClearCase scm on diff compose with @@/main/branch/id tags

Review Request #3215 — Created July 13, 2012 and discarded

fulgas
Review Board
reviewboard
I have some problems with clearcase when trying to view the diff on the UI. It couldn't find the files since the filename was composed with filename.xxx@@/main/branch/id. So managed to get the file with a specific branch outside clearcase, copy to a tmp file and then use that file to create the diff. This will allow to add filenames + branches tags on the post-review and see them on the Diff UI.

I'm new to python so it might be some issues on the patch and code standards.

I only saw a problem and that is the httpd server user needs to have permission on the clearcase otherwise you will get cleartool: Error: Operation "get cleartext" failed: Permission denied. when getting the file.

Basically i had a branch named xpto and a made a diff between filename.cpp@@/main/LATEST;filename.cpp@@main/xpto/LATEST and the result diff was uploaded to the reviewboard but i couldnt see the file in the DIFF UI. 

Hope it helps more users using clearcase.
I have tested with 1.6.9 on a dynamic view on clearcase.
Description From Last Updated

This addition doesn't add anything--if extended_path is an empty string, of course it won't have @@ in it.

daviddavid

Trailing whitespace.

daviddavid

Trailing whitespace.

daviddavid

Use # comments instead of triple-quoted strings for everything except docstrings, please.

daviddavid

What does this mean?

daviddavid

Indent these by 4 spaces.

daviddavid

No need for the parentheses here

daviddavid

Whitespace

daviddavid
FU
david
  1. 
      
  2. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
     
    This addition doesn't add anything--if extended_path is an empty string, of course it won't have @@ in it.
  3. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
     
    Trailing whitespace.
  4. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
     
     
    Trailing whitespace.
  5. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    Use # comments instead of triple-quoted strings for everything except docstrings, please.
  6. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    What does this mean?
  7. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
     
     
    Indent these by 4 spaces.
  8. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    No need for the parentheses here
  9. reviewboard/scmtools/clearcase.py (Diff revision 2)
     
     
    Whitespace
  10. 
      
jan.koprowski
  1. Hi Nelson. Jan is here. I'm creator of current ClearCase implementation.
    Your problem does not looks like ReviewBoard issue - more your configspec is wrong.
    After fixing the configspec in your view everything should back to normal.
    We can try to investigate this on group.
    
  2. 
      
FU
Review request changed

Status: Discarded

Loading...