Change Summary:
Missed a return output when there is no '@@' tag on the extended_path
Diff: |
Revision 2 (+46 -8) |
|---|
Allows to view Diff UI with ClearCase scm on diff compose with @@/main/branch/id tags
Review Request #3215 — Created July 13, 2012 and discarded
I have some problems with clearcase when trying to view the diff on the UI. It couldn't find the files since the filename was composed with filename.xxx@@/main/branch/id. So managed to get the file with a specific branch outside clearcase, copy to a tmp file and then use that file to create the diff. This will allow to add filenames + branches tags on the post-review and see them on the Diff UI. I'm new to python so it might be some issues on the patch and code standards. I only saw a problem and that is the httpd server user needs to have permission on the clearcase otherwise you will get cleartool: Error: Operation "get cleartext" failed: Permission denied. when getting the file. Basically i had a branch named xpto and a made a diff between filename.cpp@@/main/LATEST;filename.cpp@@main/xpto/LATEST and the result diff was uploaded to the reviewboard but i couldnt see the file in the DIFF UI. Hope it helps more users using clearcase.
I have tested with 1.6.9 on a dynamic view on clearcase.
| Description | From | Last Updated |
|---|---|---|
|
This addition doesn't add anything--if extended_path is an empty string, of course it won't have @@ in it. |
 david
|
|
|
Trailing whitespace. |
david
|
|
|
Trailing whitespace. |
david
|
|
|
Use # comments instead of triple-quoted strings for everything except docstrings, please. |
david
|
|
|
What does this mean? |
david
|
|
|
Indent these by 4 spaces. |
david
|
|
|
No need for the parentheses here |
david
|
|
|
Whitespace |
david
|
-
-
reviewboard/scmtools/clearcase.py (Diff revision 2) This addition doesn't add anything--if extended_path is an empty string, of course it won't have @@ in it.
-
-
-
reviewboard/scmtools/clearcase.py (Diff revision 2) Use # comments instead of triple-quoted strings for everything except docstrings, please.
-
-
-
-
