Summary

Allows to view Diff UI with ClearCase scm on diff compose with @@/main/branch/id tags

Review Request #3215 — Created July 13, 2012 and discarded Feb. 24, 2013, 10:42 p.m.

Information

Owner

fulgas

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

I have some problems with clearcase when trying to view the diff on the UI. It couldn't find the files since the filename was composed with filename.xxx@@/main/branch/id. So managed to get the file with a specific branch outside clearcase, copy to a tmp file and then use that file to create the diff. This will allow to add filenames + branches tags on the post-review and see them on the Diff UI.

I'm new to python so it might be some issues on the patch and code standards.

I only saw a problem and that is the httpd server user needs to have permission on the clearcase otherwise you will get cleartool: Error: Operation "get cleartext" failed: Permission denied. when getting the file.

Basically i had a branch named xpto and a made a diff between filename.cpp@@/main/LATEST;filename.cpp@@main/xpto/LATEST and the result diff was uploaded to the reviewboard but i couldnt see the file in the DIFF UI. 

Hope it helps more users using clearcase.

Testing Done

I have tested with 1.6.9 on a dynamic view on clearcase.

Issues

Description	From	Last Updated
This addition doesn't add anything--if extended_path is an empty string, of course it won't have @@ in it.	david	Aug. 16, 2012, 11:12 p.m.
Trailing whitespace.	david	Aug. 16, 2012, 11:12 p.m.
Trailing whitespace.	david	Aug. 16, 2012, 11:12 p.m.
Use # comments instead of triple-quoted strings for everything except docstrings, please.	david	Aug. 16, 2012, 11:12 p.m.
What does this mean?	david	Aug. 16, 2012, 11:12 p.m.
Indent these by 4 spaces.	david	Aug. 16, 2012, 11:12 p.m.
No need for the parentheses here	david	Aug. 16, 2012, 11:12 p.m.
Whitespace	david	Aug. 16, 2012, 11:12 p.m.

Change Summary:

Missed a return output when there is no '@@' tag on the extended_path

Diff:

Revision 2 (+46 -8)

Show changes

reviewboard/scmtools/clearcase.py

Fix it!

reviewboard/scmtools/clearcase.py (Diff revision 2)

An issue was opened. Show all issues

This addition doesn't add anything--if extended_path is an empty string, of course it won't have @@ in it.

reviewboard/scmtools/clearcase.py (Diff revision 2)
An issue was opened. Show all issues
```
Trailing whitespace.
```
reviewboard/scmtools/clearcase.py (Diff revision 2)
An issue was opened. Show all issues
```
Trailing whitespace.
```

reviewboard/scmtools/clearcase.py (Diff revision 2)

An issue was opened. Show all issues

Use # comments instead of triple-quoted strings for everything except docstrings, please.

reviewboard/scmtools/clearcase.py (Diff revision 2)
An issue was opened. Show all issues
```
What does this mean?
```
reviewboard/scmtools/clearcase.py (Diff revision 2)
An issue was opened. Show all issues
```
Indent these by 4 spaces.
```
reviewboard/scmtools/clearcase.py (Diff revision 2)
An issue was opened. Show all issues
```
No need for the parentheses here
```
reviewboard/scmtools/clearcase.py (Diff revision 2)
An issue was opened. Show all issues
```
Whitespace
```

Hi Nelson. Jan is here. I'm creator of current ClearCase implementation.
Your problem does not looks like ReviewBoard issue - more your configspec is wrong.
After fixing the configspec in your view everything should back to normal.
We can try to investigate this on group.

Status:: Discarded