Catch SCMErrors in repository resource.

Review Request #3168 — Created July 1, 2012 and submitted

david
Review Board
release-1.6.x
reviewboard
Catch SCMErrors in repository resource.

When RepositoryResaurce._check_repository would encounter an SCMError, it would
just blindly throw the exception up higher, returning a bare 500 error to the
client. It's not unexpected that we might hit SCMError, so here we go: return it
to the client as REPO_INFO_ERROR.


chipx86
  1. Looks fine. You beat me to a change for this :)
    
    One thing I was starting to do was to change that SCMError in svn.py to be an AuthenticationError, since an SCMError wasn't quite correct for it. I think that was from before we introduced AuthenticationError. One-line change. Mind making that too?
  2. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Loading...