Summary:

Move common comment code into BaseComment.

Review Request #3149 — Created June 17, 2012 and submitted July 31, 2012, 3:27 a.m.

Information
Owner:	chipx86
Repository:	Review Board
Branch:
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Move common comment code into BaseComment.

BaseComment is a nice base class, but wasn't doing enough. In order to
simplify maintenance, the reply_to, timestamp, text, and objects
variables and the public_replies, get_review_url, and __unicode__
functions have been moved into BaseComment.

This also introduces a get_review_request function, which is used
instead of calling self.review.get().review_request. If the
_review_request variable is assigned on the comment, it will be returned
instead, which skips a couple of otherwise necessary queries.

Testing Done

Unit tests pass. The review request page still works correctly.

I was actually meaning to move these methods into BaseComment now that these methods are a bit more modular. Thanks Christian.

reviewboard/reviews/models.py (Diff revision 1)

This prefix bugs me, I was thinking it should be "dcomment" or something more informative than just "comment".

chipx86 June 18, 2012, 12:28 p.m.

Isn't that what you had in the other change?

medanat June 18, 2012, 1:58 p.m.

It is. I used "comment" as it was the naming convention already used in the older "get_review_url()".

I'm just thinking it would be more descriptive to use "dcomment" for both branches.

chipx86 June 18, 2012, 9:16 p.m.

Problem is, we'd then break every link out there.

reviewboard/reviews/models.py (Diff revision 1)

I might be losing my mind here, but I thought I removed this function earlier and replaced it with the built-in Django filter.

chipx86 June 18, 2012, 12:28 p.m.

That was all on master. This is going on 1.6.x.

ME

medanat June 18, 2012, 1:58 p.m.
```
That makes sense.
```

Ship it!

```
Ship It!
```

Review Board 6.0 beta 2 (dev)

Move common comment code into BaseComment.

Status: Closed (submitted)