Bug fix: Display correct info in 'Diff updated' column

Review Request #3092 — Created May 2, 2012 and submitted

bogdana
Review Board
1246
reviewboard
This is a proposed fix for Issue 1246, which stated that both 'Last updated' and 'Diff updated' columns always display the same information.
In order to properly monitor diff updates, I added an extra column to the Diffsethistory table, which records the timestamp for the last added diff.
manual
python reviewboard/manage.py test
Description From Last Updated

I think you need to "git add" the evolution file (it's not visible in this change)

daviddavid

Can you add a docstring for this class?

daviddavid

Indent the extra lines just one block (4 spaces) instead of two.

daviddavid

This line can go away.

daviddavid

Can you add a docstring for this class?

daviddavid

Indent the extra lines just one block (4 spaces) instead of two.

daviddavid

This line can go away.

daviddavid
david
  1. It's going to be awesome to have this bug finally fixed!
  2. I think you need to "git add" the evolution file (it's not visible in this change)
    1. Oops, yeah, I missed that. Sorry.
  3. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    Can you add a docstring for this class?
  4. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
     
     
     
    Indent the extra lines just one block (4 spaces) instead of two.
  5. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    This line can go away.
  6. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    Can you add a docstring for this class?
  7. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
     
     
     
    Indent the extra lines just one block (4 spaces) instead of two.
  8. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    This line can go away.
  9. 
      
BO
LI
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
BO
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (937722d). Thanks!
Loading...