Summary

Bug fix: Display correct info in 'Diff updated' column

Review Request #3092 — Created May 2, 2012 and submitted May 27, 2012, 4:53 p.m.

Information

Owner

bogdana

Repository

Review Board

Branch

Bugs

1246

Depends On

Reviewers

Groups

reviewboard

People

Description

This is a proposed fix for Issue 1246, which stated that both 'Last updated' and 'Diff updated' columns always display the same information.
In order to properly monitor diff updates, I added an extra column to the Diffsethistory table, which records the timestamp for the last added diff.

Testing Done

manual
python reviewboard/manage.py test

Issues

Description	From	Last Updated
I think you need to "git add" the evolution file (it's not visible in this change)	david	May 6, 2012, 8:54 a.m.
Can you add a docstring for this class?	david	May 6, 2012, 8:54 a.m.
Indent the extra lines just one block (4 spaces) instead of two.	david	May 6, 2012, 8:54 a.m.
This line can go away.	david	May 6, 2012, 8:54 a.m.
Can you add a docstring for this class?	david	May 6, 2012, 8:54 a.m.
Indent the extra lines just one block (4 spaces) instead of two.	david	May 6, 2012, 8:54 a.m.
This line can go away.	david	May 6, 2012, 8:54 a.m.

It's going to be awesome to have this bug finally fixed!

reviewboard/diffviewer/evolutions/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I think you need to "git add" the evolution file (it's not visible in this change)
```
1. BO
  
  bogdana May 4, 2012, 1:29 a.m.
  Oops, yeah, I missed that. Sorry.
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a docstring for this class?
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Indent the extra lines just one block (4 spaces) instead of two.
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This line can go away.
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a docstring for this class?
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Indent the extra lines just one block (4 spaces) instead of two.
```
reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This line can go away.
```

Change Summary:

Updated according to David's comments.

Diff:

Revision 2 (+72 -13)

Show changes

	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/evolutions/__init__.py
	reviewboard/diffviewer/evolutions/diffsethistory_diff_updated.py
	reviewboard/reviews/datagrids.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (937722d). Thanks!