Support multiple local git commits in a git-svn repo

Review Request #3075 — Created April 23, 2012 and submitted

srwalter
RBTools
master
rbtools
If you have two local commits and want to make a review for the changes
in the most recent commit, then "ancestor" will not have a corresponding
subversion revision.  This is okay, however.  We'll just use the
subversion revision for the merge-base, which is the most-recent-commit
that is in SVN.
Logically behavior is only changed in cases where we would crash, before.  Returning "None" causes len(None) to throw an exception.

Making a review using "post-review --revision-range=HEAD^" in a git-svn repository with multiple local commits results in the expected behavior: a review is created and the diff shows only the changes from HEAD.
Description From Last Updated

A comment here would be nice explaining the second attempt.

ME medanat

This is longer than 80 characters, I believe.

ME medanat
SR
  1. What's a guy got to do to get some code review around here??
  2. 
      
ME
  1. Some style issues. I can't help you with the correctness or necessity of this patch.
  2. rbtools/clients/git.py (Diff revision 1)
     
     
     
     
     
     
    A comment here would be nice explaining the second attempt.
  3. rbtools/clients/git.py (Diff revision 1)
     
     
    This is longer than 80 characters, I believe.
  4. 
      
david
  1. Sorry this took so long. I've fixed up the couple issues and pushed it.
  2. 
      
SR
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (dc0b739). Thanks!
Loading...