Support multiple local git commits in a git-svn repo
Review Request #3075 — Created April 23, 2012 and submitted
If you have two local commits and want to make a review for the changes in the most recent commit, then "ancestor" will not have a corresponding subversion revision. This is okay, however. We'll just use the subversion revision for the merge-base, which is the most-recent-commit that is in SVN.
Logically behavior is only changed in cases where we would crash, before. Returning "None" causes len(None) to throw an exception. Making a review using "post-review --revision-range=HEAD^" in a git-svn repository with multiple local commits results in the expected behavior: a review is created and the diff shows only the changes from HEAD.
| Description | From | Last Updated |
|---|---|---|
|
A comment here would be nice explaining the second attempt. |
ME medanat | |
|
This is longer than 80 characters, I believe. |
ME medanat |
ME
-
Some style issues. I can't help you with the correctness or necessity of this patch.
-
rbtools/clients/git.py (Diff revision 1) A comment here would be nice explaining the second attempt.
-
