Summary

Support multiple local git commits in a git-svn repo

Review Request #3075 — Created April 23, 2012 and submitted Aug. 10, 2013, 3:55 p.m.

Information

Owner

srwalter

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

If you have two local commits and want to make a review for the changes
in the most recent commit, then "ancestor" will not have a corresponding
subversion revision.  This is okay, however.  We'll just use the
subversion revision for the merge-base, which is the most-recent-commit
that is in SVN.

Testing Done

Logically behavior is only changed in cases where we would crash, before.  Returning "None" causes len(None) to throw an exception.

Making a review using "post-review --revision-range=HEAD^" in a git-svn repository with multiple local commits results in the expected behavior: a review is created and the diff shows only the changes from HEAD.

Issues

Description	From	Last Updated
A comment here would be nice explaining the second attempt.	ME medanat	Aug. 15, 2012, 6:43 a.m.
This is longer than 80 characters, I believe.	ME medanat	Aug. 15, 2012, 6:43 a.m.

What's a guy got to do to get some code review around here??

Fix it!

Some style issues. I can't help you with the correctness or necessity of this patch.

rbtools/clients/git.py (Diff revision 1)

An issue was opened. Show all issues

A comment here would be nice explaining the second attempt.

rbtools/clients/git.py (Diff revision 1)
An issue was opened. Show all issues
```
This is longer than 80 characters, I believe.
```

Ship it!

Sorry this took so long. I've fixed up the couple issues and pushed it.

Status:: Completed
Change Summary:: Pushed to master (dc0b739). Thanks!