Move public JavaScript functions into the RB namespace.

Review Request #3048 — Created April 9, 2012 and submitted

Information

Review Board

Reviewers

Move public JavaScript functions into the RB namespace.

Pipeline now wraps all compressed JavaScript files in its own scope,
causing any functions defined within to be inaccessible outside the file
(such as to the <script> tags in the HTML). So now, we just stick these
in the RB namespace, like the API.

Down the road, we'll want to probably refactor these to be a bit more
object-oriented and better namespaced.
Ran it here, and it seemed to work. It's possible that in a deployment,
we may find some issues between functions from one script calling another,
but I haven't hit any yet.
Description From Last Updated

Indentation here is a littly funky.

daviddavid
david
  1. 
      
  2. reviewboard/static/rb/js/diffviewer.js (Diff revision 1)
     
     
     
     
    Show all issues
    Indentation here is a littly funky.
    1. Where? Looks right to me.
    2. The second two lines look like they have 1 too many spaces.
    3. Hmm, I'm not seeing that here or in my change. This sounds familiar though. I feel like we hit some glitch before in rendering in your browser? I can provide a screenshot.
  3. 
      
chipx86
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (418d0773c7113c1a962a9daad0a125b2a0f95ee4)