Summary

Replace truncate_text function with the built-in filter.

Review Request #3047 — Created April 7, 2012 and submitted April 9, 2012, 1:57 a.m.

Information

Owner

medanat

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Replace truncate_text with the built in filter: https://docs.djangoproject.com/en/dev/releases/1.4/#truncatechars-template-filter.
Changed column header text to reflect column contents.

Testing Done

Local Machine: Ubuntu 11.04, Chrome 17, Firefox 11.

Change Summary:

Blank lines fix.

Diff:

Revision 2 (+12 -15)

Show changes

	reviewboard/changedescs/admin.py
	reviewboard/changedescs/models.py
	reviewboard/reviews/admin.py
	reviewboard/reviews/models.py

Change Summary:: Changed Summary.
Summary:: Remove truncate_text function with the built-in filter.
Replace truncate_text function with the built-in filter.

Ship it!

Looks fine to me. I did some greping to make sure you covered all places the old function was used.

reviewboard/changedescs/admin.py (Diff revision 2)
```
I agree that truncated is more readable.
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed