Summary

Review Bot

Review Request #3042 — Created April 4, 2012 and submitted Aug. 27, 2012, 5:25 p.m.

Information

Owner

smacleod

Repository

ReviewBot

Branch

Bugs

Depends On

Reviewers

Groups

rbtools, reviewboard

People

Description

This is the prototype for Review Bot.

Currently it consists of two parts: 
1. A Review Board extension for queueing review requests and configuration.
2. A Celery task which will process review requests, running tools defined in the reviewbot.tools entry point.

The API code is mostly taken from RBTools, and I am aware of many problems with it. I'm hoping the new API will come soon and I can upgrade the code. Please try and focus reviewing effort to other parts of the code.

Testing Done

Reviewed some of the old Review Board code with various settings.

Screenshots

Admin Panel

Some Reviews

Issues

Description	From	Last Updated
I think it would be cool if it highlighted the column also!	DD ddruska	Aug. 27, 2012, 5:24 p.m.
Maybe stick with double quotes.	DD ddruska	Aug. 27, 2012, 5:24 p.m.
Since Python 2.5+ is required for Django 1.4, maybe skip mentioning 2.4	DD ddruska	Aug. 27, 2012, 5:24 p.m.
This should be a one-liner.	DD ddruska	Aug. 27, 2012, 5:24 p.m.
Why the '+='? Can't this all be in the '='?	DD ddruska	Aug. 27, 2012, 5:24 p.m.
Unreachable code.	DD ddruska	Aug. 27, 2012, 5:24 p.m.
I think you can just call "raise" to re-raise exceptions, without having to specify 'e'.	DD ddruska	Aug. 27, 2012, 5:24 p.m.
Indentation looks off.	DD ddruska	Aug. 27, 2012, 5:25 p.m.
Indentation looks off.	DD ddruska	Aug. 27, 2012, 5:25 p.m.

Change Summary:: Added some screenshots.
Screenshots:: Admin Panel
Some Reviews

Some Reviews

The issue has been dropped. Show all issues

I think it would be cool if it highlighted the column also!

bot/reviewbot/processing/api.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Maybe stick with double quotes.
```
bot/reviewbot/processing/api.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Since Python 2.5+ is required for Django 1.4, maybe skip mentioning 2.4
```

bot/reviewbot/processing/api.py (Diff revision 1)

Same as before. Do you still need to worry about Python 2.4?

bot/reviewbot/processing/api.py (Diff revision 1)
The issue has been dropped. Show all issues
```
This should be a one-liner.
```

bot/reviewbot/processing/api.py (Diff revision 1)

The issue has been dropped. Show all issues

Why the '+='? Can't this all be in the '='?

bot/reviewbot/processing/api.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Unreachable code.
```

bot/reviewbot/processing/api.py (Diff revision 1)

The issue has been dropped. Show all issues

I think you can just call "raise" to re-raise exceptions, without having to specify 'e'.

bot/reviewbot/processing/api.py (Diff revision 1)

The issue has been dropped. Show all issues

Indentation looks off.

bot/reviewbot/processing/api.py (Diff revision 1)

The issue has been dropped. Show all issues

Indentation looks off.

Status:: Completed