Review Bot

Review Request #3042 — Created April 4, 2012 and submitted

smacleod
ReviewBot
rbtools, reviewboard
This is the prototype for Review Bot.

Currently it consists of two parts: 
1. A Review Board extension for queueing review requests and configuration.
2. A Celery task which will process review requests, running tools defined in the reviewbot.tools entry point.

The API code is mostly taken from RBTools, and I am aware of many problems with it. I'm hoping the new API will come soon and I can upgrade the code. Please try and focus reviewing effort to other parts of the code.
Reviewed some of the old Review Board code with various settings.
Description From Last Updated

I think it would be cool if it highlighted the column also!

DD ddruska

Maybe stick with double quotes.

DD ddruska

Since Python 2.5+ is required for Django 1.4, maybe skip mentioning 2.4

DD ddruska

This should be a one-liner.

DD ddruska

Why the '+='? Can't this all be in the '='?

DD ddruska

Unreachable code.

DD ddruska

I think you can just call "raise" to re-raise exceptions, without having to specify 'e'.

DD ddruska

Indentation looks off.

DD ddruska

Indentation looks off.

DD ddruska
SM
DD
  1. 
      
  2. I think it would be cool if it highlighted the column also!
  3. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
     
     
     
    Maybe stick with double quotes.
  4. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
    Since Python 2.5+ is required for Django 1.4, maybe skip mentioning 2.4
  5. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
     
     
     
    Same as before. Do you still need to worry about Python 2.4?
  6. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
     
     
    This should be a one-liner.
  7. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Why the '+='? Can't this all be in the '='?
  8. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
    Unreachable code.
  9. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
    I think you can just call "raise" to re-raise exceptions, without having to specify 'e'.
  10. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
     
     
     
     
     
     
    Indentation looks off.
  11. bot/reviewbot/processing/api.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Indentation looks off.
  12. 
      
SM
Review request changed

Status: Closed (submitted)

Loading...