Caught DoesNotExist exceptions in WebAPI, now raises 404

 






 

 


  Review Request #3041
  —
  Created April 3, 2012 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  ammok
 









 
 

  Djblets
 









 
 

  
 









 
 

  2551
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This addresses issue 2551.

Caught the DoesNotExist exceptions in the web API, and raised a HTTP 404 exception instead.

Unfortunately, it looks like I missed a space at the end of one line.
The (potential) problem I have with this one is that it will catch any DoesNotExist exception (rather than just the one associated with the review_request_resource model).

 








  


 
 

  
Testing done in Linux 3.2.13 with Chromium 18.0.

I visited local links that pointed to invalid review requests:
http://localhost:8080/api/review-requests/99/diffs/1/files/1/diff-comments/
[03/Apr/2012 22:37:30] "GET /api/review-requests/99/diffs/1/files/1/diff-comments/ HTTP/1.1" 404 139
http://localhost:8080/api/review-requests/999999999/screenshots/
[03/Apr/2012 22:40:35] "GET /api/review-requests/999999999/screenshots/ HTTP/1.1" 404 139

 







 









 





  








 




 







   

    
    

    

    


    


      

       
      

    

    

   

  

 





    


    

    





     
    
    
    
   
    
  
    
  
    
   
   Loading...