Print debugging info when a subcommand fails, even when ignore_errors is true.

 






 

 


  Review Request #3007
  —
  Created March 24, 2012 and submitted 

 


















 

  

   Information

  





 
 

  csilvers
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
When a subcommand gives an error and ignore_errors is false, we die with the error output.  But when ignore_errors is true, there's no way to see the error output, even when running with -d.  This change fixes that but emitting the error output in debug mode.

I also changed the log messages a bit when running a command, to make it clear that we're running a subcommand.

(Note: for some reason, the diff doesn't apply cleanly, so if you click on the 'view diff' button you'll just get an error message.  But this is a small diff, so hopefully you can download the diff and apply the changes by hand, if you're interested in taking this change.)

 








  


 
 

  

 







 









 





  








 









 






  

 








 














 





 

  

   




chipx86




   

   





  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Mixed feelings on this change. Yes, that information can be useful, but there are definitely commands we run that we basically expect will fail (such as when scanning the type of repository), and from past experience, many of our users will get really on the wrong track when we show such stuff. I'm concerned they'll see some error for, say, Subversion, and think that's the reason their review request failed to publish, when it may be totally unrelated.

Can you think of another way to get what you want here without having that issue? Maybe "Ignoring error: <blah>". (Though maybe they'd then think the problem is that the error was ignored :)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I understand.  I've rewritten it to try to address this.  See new attached diff.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 CS





   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 CS





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
Pushed to master (2612bfd)





 


 










  

 









     

    

   

  

  

   
   Loading...