the update bubble will now distinguish between review requests that are updated, submitted or discarded

Review Request #3001 - Created March 22, 2012 and submitted

Jim Chen
Review Board
reviewboard
The update bubble will now say a review request is updated, submitted or discarded instead of just say it is updated
Tested in Linux with Chrome 17 and Firefox 11
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Dave Druska
  1. The only improvement I can think of is reducing repeated code by appending the statuses onto the string (after "Review request "), but this might be overkill for this situation!
  2. 
      
Christian Hammond
  1. So, this gets us part of the way there, but what happens if you modify a review request that is already submitted?
    
    What this needs to do is check the latest ChangeDescription on the review request. If that latest one says that the status changed, then do this logic. Otherwise, fall back on "Review request updated."
    1. Currently there is not way to modify to a review request once it is submitted/discarded. So we can't really show the request is "updated" while it is already submitted/discarded. It would just behave as user would expect and show that it is submitted/discarded
  2. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    Blank line before this.
  3. reviewboard/webapi/resources.py (Diff revision 1)
     
     
    Blank line after.
  4. 
      
Jim Chen
Mike Conley
  1. This looks good to me.  Good work!
  2. 
      
Christian Hammond
  1. Ship It!
  2. 
      
Jim Chen
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (2b29ae7) and merged to master.
Loading...