Summary

the update bubble will now distinguish between review requests that are updated, submitted or discarded

Review Request #3001 — Created March 22, 2012 and submitted March 31, 2012, 6:36 p.m.

Information

Owner

jimrrchen

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The update bubble will now say a review request is updated, submitted or discarded instead of just say it is updated

Testing Done

Tested in Linux with Chrome 17 and Firefox 11

Issues

Description	From	Last Updated
Blank line before this.	chipx86	March 24, 2012, 7:03 a.m.
Blank line after.	chipx86	March 24, 2012, 7:03 a.m.

Ship it!

The only improvement I can think of is reducing repeated code by appending the statuses onto the string (after "Review request "), but this might be overkill for this situation!

So, this gets us part of the way there, but what happens if you modify a review request that is already submitted?

What this needs to do is check the latest ChangeDescription on the review request. If that latest one says that the status changed, then do this logic. Otherwise, fall back on "Review request updated."

jimrrchen March 31, 2012, 7:51 a.m.

Currently there is not way to modify to a review request once it is submitted/discarded. So we can't really show the request is "updated" while it is already submitted/discarded. It would just behave as user would expect and show that it is submitted/discarded

reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before this.
```
reviewboard/webapi/resources.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line after.
```

Change Summary:

added blank lines before and after if-block

Diff:

Revision 2 (+8 -1)

Show changes

reviewboard/webapi/resources.py

Ship it!

```
This looks good to me.  Good work!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.6.x (2b29ae7) and merged to master.