Add a JSON API function for logging in

Review Request #3 — Created May 20, 2007 and submitted

chipx86
Review Board SVN (deprecated)
trunk
reviewboard
Added a JSON API function for logging in to Review Board. This allows the caller to get a nice JSON response code instead of calling the existing /accounts/login/ page, which would end up returning a redirect on success and an HTML page with an embedded error on failure.
Attempted a login using the new function. It appeared to work fine, as I was then able to post a review request.
david
  1. Just a couple nits.
  2. /trunk/reviewboard/reviews/json.py (Diff revision 1)
     
     
    "if not user" would be a bit more readable, IMO.
  3. There's no reason to save the return value here.
    1. Updated to remove the result and to catch the error and die.
    2. I like it.
  4. 
      
Loading...