Summary

Add a JSON API function for logging in

Review Request #3 — Created May 20, 2007 and submitted

Information

Owner

chipx86

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added a JSON API function for logging in to Review Board. This allows the caller to get a nice JSON response code instead of calling the existing /accounts/login/ page, which would end up returning a redirect on success and an HTML page with an embedded error on failure.

Testing Done

Attempted a login using the new function. It appeared to work fine, as I was then able to post a review request.

Ship it!

```
Just a couple nits.
```
/trunk/reviewboard/reviews/json.py (Diff revision 1)
```
"if not user" would be a bit more readable, IMO.
```
1. chipx86 May 20, 2007, 6:22 p.m.
  Fixed.

/trunk/reviewboard/contrib/perforce/post-review (Diff revision 1)

There's no reason to save the return value here.

chipx86 May 20, 2007, 6:22 p.m.

Updated to remove the result and to catch the error and die.

david May 20, 2007, 6:22 p.m.
```
I like it.
```