-
-
reviewboard/scmtools/bzr.py (Diff revision 1) Module names should be alphabetized, and the imports for datetime and timedelta should go on the same line (from datetime impor datetime, timedelta).
-
reviewboard/scmtools/bzr.py (Diff revision 1) Two blank lines before the class definition. Could you briefly document the BZRTool, explain its purpose?
-
-
reviewboard/scmtools/bzr.py (Diff revision 1) Excess trailing whitespace. Here and elsewhere in the file.
-
reviewboard/scmtools/bzr.py (Diff revision 1) What's the difference between rev and revision? Could you add a comment explaining this?
-
reviewboard/scmtools/bzr.py (Diff revision 1) These look indented too far. Also, I'm not wild about referencing the values by position. Can you instead split the line and check the parts for "revno:" and "timestamp:" and grab the value that way?
-
reviewboard/scmtools/bzr.py (Diff revision 1) There's probably a better way to structure this. There's a lot of magic numbers for positions in here. What's this supposed to do?
-
reviewboard/scmtools/bzr.py (Diff revision 1) Mix of spaces and tabs for the leading whitespace. It should be spaces only.
Bazaar SCM tool support
Review Request #296 — Created March 15, 2008 and submitted
Information | |
---|---|
hhedberg | |
Review Board SVN (deprecated) | |
Reviewers | |
reviewboard | |
Adds Bazaar (bzr) SCM tool support. It is implemented simply by invoking external application (like the cvs support too). However, Bazaar diffs do not contain revision numbers but timestamps. The solution is to find the corresponding revision number in parse_diff_revision function using bzr log. This is my very first piece of Python code. I submit this, since there might be some other Bazaar users who are willing to participate or help. All comments are welcome. :)
Tested with simple Bazaar repository. I invite all Bazaar users to help testing this.
HH
-
This is my second attempt.
-
reviewboard/scmtools/bzr.py (Diff revision 2) Unfortunately this system did not let me update tbe diff twice, and thus these extra spaces are still here.
-
I went ahead and made various style changes and committed this as r1300. Thanks!
-
reviewboard/scmtools/bzr.py (Diff revision 2) This should be up in the standard-library group, alphabetically.