Support LDAP authentication without using anonymous bind credentials

Review Request #2909 — Created Feb. 20, 2012 and submitted

Information

Review Board

Reviewers

This change modifies the search for user information so that when the Anonymous credentials are not configured, the credentials entered by the user attempting to log in are used to bind to the LDAP service in order to do the search.


I've tested this with our LDAP server, which is configured not to allow any anonymous search; I believe that I did not change the behavior for the case in which the anonymous credentials are configured (if I configure them, it does the same sequence of operations to the LDAP server, but since they don't work I cannot be 100% sure).
Description From Last Updated

Capitalize the "a" in attempt. i.e.: Attempt

ME medanat
ME
  1. I honestly don't know what this code is doing, but I have one small remark.
    
    I'm sure someone much smarter than me will get to this soon enough.
  2. reviewboard/accounts/backends.py (Diff revision 1)
     
     
    Show all issues
    Capitalize the "a" in attempt.
    
    i.e.: Attempt
  3. 
      
david
  1. Ship It!
  2. 
      
OZ
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master with slight formatting modifications (4f95ceb). Thanks!
Loading...