Summary

Support LDAP authentication without using anonymous bind credentials

Review Request #2909 — Created Feb. 20, 2012 and submitted March 18, 2012, 9:02 a.m.

Information

Owner

oz.linden

Repository

Review Board

Branch

Bugs

2493

Depends On

Reviewers

Groups

reviewboard

People

Description

This change modifies the search for user information so that when the Anonymous credentials are not configured, the credentials entered by the user attempting to log in are used to bind to the LDAP service in order to do the search.

Testing Done

I've tested this with our LDAP server, which is configured not to allow any anonymous search; I believe that I did not change the behavior for the case in which the anonymous credentials are configured (if I configure them, it does the same sequence of operations to the LDAP server, but since they don't work I cannot be 100% sure).

Issues

Description	From	Last Updated
Capitalize the "a" in attempt. i.e.: Attempt	ME medanat	Feb. 21, 2012, 12:04 p.m.

Fix it!

I honestly don't know what this code is doing, but I have one small remark.

I'm sure someone much smarter than me will get to this soon enough.

reviewboard/accounts/backends.py (Diff revision 1)
An issue was opened. Show all issues
```
Capitalize the "a" in attempt.

i.e.: Attempt
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master with slight formatting modifications (4f95ceb). Thanks!