Got any screenshots showing a moved file with a couple changes?

Got any screenshots showing a moved file with a couple changes?

Would it make sense to highlight that a change was made here? When quickly viewing the review request the name change isn't obvious. Maybe this could be highlighted yellow like in the code, or have some sort of icon?

For multi-line conditions, use parens instead of \. Also make sure that the alignment is consistent on each.

Blank line before this.

I know we didn't do this with deleted, but this should compare against self.MOVED. (You can update deleted to do that too.)

This should go inside the conditional's body. So:

if ....
    # Moved ...

I don't love the negation method. I find it's easier to read it if each check stands alone whenever possible.

Best not to modify unrelated lines. It distracts from the main purpose of the review, muddies up the history of lines a bit, and can cause merge conflicts if other people modify the same lines. In this case, that's exactly what's happening, because I rewrote these functions, so there will be some merge ugliness.

Using Django 1.4 (that will be required as soon as an upstream thing is fixed in a module we depend on), you can change this to use {% elif ... %}

"length"

If you add a "(moved)" suffix to the file name, this can just be:

"No changes were made to this file."

Ship It!