Social Review Rating Extension

Review Request #2900 — Created Feb. 19, 2012 and discarded

Information

Review Board

Reviewers

Continuing from design review: http://reviews.reviewboard.org/r/2843/

Committing progress so far as requested by Mike. Somewhat functional skeleton prototype, still a work in progress.

 
Description From Last Updated

2 blank lines here

SM smacleod

2 blank lines here

SM smacleod

I'm not sure how.

SM smacleod

two blank lines here

SM smacleod

Blank line between these

SM smacleod

2 blank lines between

SM smacleod

Need to end file with a newline

SM smacleod

Need to end file with newline

SM smacleod

{% url social-rate %} causes a NoReverseMatch exception when posting a review. I'm not sure what's wrong here since I …

SM smacleod

I'm assuming the django form isn't working so you have this here still for testing?

SM smacleod

Need 2 blank lines here

SM smacleod

LocalSite is undefined

SM smacleod

Need two blank lines here Also _render_permission_denied() has not been imported. reviewboard/reviews/views.py

SM smacleod

Need two blank lines here

SM smacleod

> 80 characters

SM smacleod

LocalSite is undefined

SM smacleod

_render_permission_denied() has not been imported. This helper function is in reviewboard/reviews/views.py

SM smacleod

Need 2 blank lines here

SM smacleod

> 80 characters / need >=2 spaces before inline comment

SM smacleod

> 80 characters

SM smacleod

_() has not been imported (from django.utils.translation import ugettext as _)

SM smacleod

Need newline at end of file

SM smacleod
SM
  1. Looks like a pretty good start. I focused on style and some static checking.
    
    You should avoid including your editor backup files in the patch (.py~). You might want to consider adding .py~ to your git ignore list.
    
    Also, as Anthony had noted in my Web Hooks extension, the __init__.py file is missing from your patch (since it is empty). 
  2. social/social/extension.py (Diff revision 1)
     
     
     
     
    Show all issues
    2 blank lines here
  3. social/social/extension.py (Diff revision 1)
     
     
     
     
    Show all issues
    2 blank lines here
  4. social/social/extension.py (Diff revision 1)
     
     
    Show all issues
    I'm not sure how.
    1. Didn't mean to open an issue, feel free to drop.
  5. social/social/extension.py (Diff revision 1)
     
     
     
     
    Show all issues
    two blank lines here
  6. social/social/extension.py (Diff revision 1)
     
     
     
    Show all issues
    Blank line between these
  7. social/social/forms.py (Diff revision 1)
     
     
     
     
    Show all issues
    2 blank lines between
  8. social/social/forms.py (Diff revision 1)
     
     
    Show all issues
    Need to end file with a newline
  9. social/social/models.py (Diff revision 1)
     
     
    Show all issues
    Need to end file with newline
  10. Show all issues
    {% url social-rate %} causes a NoReverseMatch exception when posting a review. I'm not sure what's wrong here since I checked and the url has been added: ^ ^social/ ^rate/$ [name='social-rate']
  11. social/social/templates/social/rate.html (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues
    I'm assuming the django form isn't working so you have this here still for testing?
  12. social/social/views.py (Diff revision 1)
     
     
     
     
    Show all issues
    Need 2 blank lines here
  13. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    LocalSite is undefined
  14. social/social/views.py (Diff revision 1)
     
     
     
     
    Show all issues
    Need two blank lines here
    
    Also _render_permission_denied() has not been imported. reviewboard/reviews/views.py
  15. social/social/views.py (Diff revision 1)
     
     
     
     
    Show all issues
    Need two blank lines here
  16. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    > 80 characters
  17. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    LocalSite is undefined
  18. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    _render_permission_denied() has not been imported. This helper function is in reviewboard/reviews/views.py
  19. social/social/views.py (Diff revision 1)
     
     
     
     
    Show all issues
    Need 2 blank lines here
  20. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    > 80 characters / need >=2 spaces before inline comment
  21. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    > 80 characters
  22. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    _() has not been imported
    
    (from django.utils.translation import ugettext as _)
  23. social/social/views.py (Diff revision 1)
     
     
    Show all issues
    Need newline at end of file
  24. 
      
CI
Review request changed
Status:
Discarded