Summary

Social Review Rating Extension

Review Request #2900 — Created Feb. 19, 2012 and discarded Aug. 2, 2013, 12:25 p.m.

Information

Owner

cim1

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

mike_conley

Description

Continuing from design review: http://reviews.reviewboard.org/r/2843/

Committing progress so far as requested by Mike. Somewhat functional skeleton prototype, still a work in progress.

Testing Done

Issues

Description	From	Last Updated
2 blank lines here	SM smacleod	Feb. 20, 2012, 12:56 a.m.
2 blank lines here	SM smacleod	Feb. 20, 2012, 12:56 a.m.
I'm not sure how.	SM smacleod	Feb. 20, 2012, 12:56 a.m.
two blank lines here	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Blank line between these	SM smacleod	Feb. 20, 2012, 12:56 a.m.
2 blank lines between	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need to end file with a newline	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need to end file with newline	SM smacleod	Feb. 20, 2012, 12:56 a.m.
{% url social-rate %} causes a NoReverseMatch exception when posting a review. I'm not sure what's wrong here since I …	SM smacleod	Feb. 20, 2012, 12:56 a.m.
I'm assuming the django form isn't working so you have this here still for testing?	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need 2 blank lines here	SM smacleod	Feb. 20, 2012, 12:56 a.m.
LocalSite is undefined	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need two blank lines here Also _render_permission_denied() has not been imported. reviewboard/reviews/views.py	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need two blank lines here	SM smacleod	Feb. 20, 2012, 12:56 a.m.
> 80 characters	SM smacleod	Feb. 20, 2012, 12:56 a.m.
LocalSite is undefined	SM smacleod	Feb. 20, 2012, 12:56 a.m.
_render_permission_denied() has not been imported. This helper function is in reviewboard/reviews/views.py	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need 2 blank lines here	SM smacleod	Feb. 20, 2012, 12:56 a.m.
> 80 characters / need >=2 spaces before inline comment	SM smacleod	Feb. 20, 2012, 12:56 a.m.
> 80 characters	SM smacleod	Feb. 20, 2012, 12:56 a.m.
_() has not been imported (from django.utils.translation import ugettext as _)	SM smacleod	Feb. 20, 2012, 12:56 a.m.
Need newline at end of file	SM smacleod	Feb. 20, 2012, 12:56 a.m.

Fix it!

Looks like a pretty good start. I focused on style and some static checking.

You should avoid including your editor backup files in the patch (.py~). You might want to consider adding .py~ to your git ignore list.

Also, as Anthony had noted in my Web Hooks extension, the __init__.py file is missing from your patch (since it is empty).

social/social/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
2 blank lines here
```
social/social/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
2 blank lines here
```
social/social/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
I'm not sure how.
```
1. SM
  
  smacleod Feb. 20, 2012, 12:57 a.m.
  Didn't mean to open an issue, feel free to drop.
social/social/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
two blank lines here
```
social/social/extension.py (Diff revision 1)
An issue was opened. Show all issues
```
Blank line between these
```
social/social/forms.py (Diff revision 1)
An issue was opened. Show all issues
```
2 blank lines between
```
social/social/forms.py (Diff revision 1)
An issue was opened. Show all issues
```
Need to end file with a newline
```
social/social/models.py (Diff revision 1)
An issue was opened. Show all issues
```
Need to end file with newline
```

social/social/templates/social/rate.html (Diff revision 1)

An issue was opened. Show all issues

{% url social-rate %} causes a NoReverseMatch exception when posting a review. I'm not sure what's wrong here since I checked and the url has been added: ^ ^social/ ^rate/$ [name='social-rate']

social/social/templates/social/rate.html (Diff revision 1)

An issue was opened. Show all issues

I'm assuming the django form isn't working so you have this here still for testing?

social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Need 2 blank lines here
```
social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
LocalSite is undefined
```

social/social/views.py (Diff revision 1)

An issue was opened. Show all issues

Need two blank lines here

Also _render_permission_denied() has not been imported. reviewboard/reviews/views.py

social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Need two blank lines here
```
social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
> 80 characters
```
social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
LocalSite is undefined
```

social/social/views.py (Diff revision 1)

An issue was opened. Show all issues

_render_permission_denied() has not been imported. This helper function is in reviewboard/reviews/views.py

social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Need 2 blank lines here
```
social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
> 80 characters / need >=2 spaces before inline comment
```
social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
> 80 characters
```

social/social/views.py (Diff revision 1)

An issue was opened. Show all issues

_() has not been imported

(from django.utils.translation import ugettext as _)

social/social/views.py (Diff revision 1)
An issue was opened. Show all issues
```
Need newline at end of file
```

Status:: Discarded