Added showRequiredFlag option to inlineEditor

Review Request #2889 — Created Feb. 17, 2012 and submitted

Information

Djblets

Reviewers

Added showRequiredFlag option to inlineEditor.

This review is part of review 2881.

 
Description From Last Updated

This can be combined to one statement. The indentation for the values on the $("") should be indented one more …

chipx86chipx86

This should be indented 2 more spaces.

mike_conleymike_conley
ME
ME
chipx86
  1. 
      
  2. djblets/media/js/jquery.gravy.js (Diff revision 1)
     
     
     
     
     
     
     
     
    This can be combined to one statement.
    
    The indentation for the values on the $("<span/>") should be indented one more level, as they apply to the span.
  3. 
      
ME
mike_conley
  1. Just one nit, Yazan.  Other than that, this looks good to me (assuming we decided that the * was an OK indicator for required fields)
  2. djblets/media/js/jquery.gravy.js (Diff revision 2)
     
     
     
     
    This should be indented 2 more spaces.
  3. 
      
ME
chipx86
  1. Looks good, though you're using tabs instead of spaces. Be careful about that in future changes. I've fixed it in the patch and will commit to master.
  2. 
      
ME
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (28f8a36)
Loading...