Added showRequiredFlag option to inlineEditor
Review Request #2889 — Created Feb. 17, 2012 and submitted
| Information | |
|---|---|
| medanat | |
| Djblets | |
| Reviewers | |
| djblets | |
Added showRequiredFlag option to inlineEditor. This review is part of review 2881.
| Description | From | Last Updated |
|---|---|---|
|
This can be combined to one statement. The indentation for the values on the $("") should be indented one more … |
 chipx86
|
|
|
This should be indented 2 more spaces. |
 mike_conley
|
ME
Status: Re-opened
Summary: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||
Groups: |
|
|||||||||
Diff: |
Revision 1 (+10) |
-
-
djblets/media/js/jquery.gravy.js (Diff revision 1) This can be combined to one statement. The indentation for the values on the $("<span/>") should be indented one more level, as they apply to the span.
ME
Change Summary:
Indented values for the span element. Combined code into one statement.
Diff: |
Revision 2 (+8) |
|---|
-
Just one nit, Yazan. Other than that, this looks good to me (assuming we decided that the * was an OK indicator for required fields)
-