Added * flag to required review request fields

Review Request #2881 — Created Feb. 13, 2012 and submitted

Information

Review Board

Reviewers

Added * flag to required review request fields.

The rest of this review is in review 2889 under djblets.
Visually inspected on Chrome 14, on ubuntu 11.04.
Description From Last Updated

There should be more of a margin above this. Maybe another 0.5em.

chipx86chipx86

You're right, that is a problem. So for this particular case, I'd just not show the "*" for these fields …

chipx86chipx86

I'd just call this "required".

chipx86chipx86

There's no point in showing the asterisk to users unless they can modify the review request. Perhaps instead, have the …

chipx86chipx86

This should also only be shown when you can edit.

chipx86chipx86

Should the {% if %} and {% endif %} blocks really be indented? I've seen some of our other template …

mike_conleymike_conley
SM
  1. Looks good, should be helpful.
  2. This is really nit-picky, but I feel like there could be a little more space between the input for testing and the legend. Compared to the rest of the spacing it seems a little cramped to me
    1. I'll play around with the padding, see if I can make it look less cramped. Thanks.
  3. I'm not sure why this is called required-field-legacy. What do you mean by legacy? Is this a convention I don't know about?
    1. I meant to say legend, thanks for spotting that. I'll fix it.
  4. 
      
chipx86
  1. Hmm, so the asterisk works in theory, but I'm not sure I love the placement in practice. I wonder if we can play with this a bit more.
    
    Partly, the asterisk is too small. It's nothing but a dot in the screenshot.
    
    There's a different route I'm thinking of, that I'd love for you to try. That would be placing it essentially by the pencil icon, a bit larger. This ties it to the thing you click to edit, rather than being on the other side of the label.
  2. Show all issues
    I'd just call this "required".
  3. Show all issues
    There's no point in showing the asterisk to users unless they can modify the review request. Perhaps instead, have the function that sets up the editor take an argument for whether or not it's required. It can then place the asterisk when it adds the pencil (ensuring it'll only ever be seen if the user can edit).
  4. Show all issues
    This should also only be shown when you can edit.
  5. 
      
ME
ME
chipx86
  1. 
      
  2. Show all issues
    There should be more of a margin above this. Maybe another 0.5em.
  3. Show all issues
    You're right, that is a problem.
    
    So for this particular case, I'd just not show the "*" for these fields and stick that on Reviewers. 
  4. 
      
ME
chipx86
  1. This looks fine, but doesn't apply anymore. Can you update?
  2. 
      
ME
mike_conley
  1. I can't view your diff, it seems. :/
  2. 
      
mike_conley
  1. Looks pretty good - just one question.
  2. Show all issues
    Should the {% if %} and {% endif %} blocks really be indented?  I've seen some of our other template code where we use:
    
    {% if x %}
          <span class="required">*</span>
    {%    if y %}
          <span class="other-required">*</span>
    {%    endif %}
    {% endif %}
    
    So perhaps the if/endif should not be indented at all?
    1. I've seen both styles in the templates, I'm just not sure which one is the preferred approach. I followed the style of the surrounding chunk of code.
    2. Indentation should happen within the {% ... %}. The reason is that it minimizes the whitespace outputted to the browser, which means less data having to be transferred. It also resolves issues with consistency between indented tags and template tags when you're doing something fancy where they wouldn't necessarily be around an opening tag and closing tag.
  3. 
      
ME
DD
  1. Looks good to me.
  2. 
      
chipx86
  1. Ship It!
  2. 
      
ME
Review request changed
Status:
Completed
Change Summary:
Pushed to master (ff88a59)