Summary

Added a preview email page for changedescs.

Review Request #2858 — Created Feb. 11, 2012 and submitted Feb. 14, 2012, 4:55 p.m.

Information

Owner

ammok

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Added a preview email page for changedescs.

This page takes the form of: http://{fqdn}/r/{review_request_id}/changedescs/{changedesc_id}/preview-email/{html|text}/

Testing Done

Local User Testing done on Linux 3.2.4 using Chromium 17.0.963.46

Screenshots

Local Preview Page Example

Issues

Description	From	Last Updated
Maybe "/changes" instead of "/changedescs".	chipx86	Feb. 13, 2012, 8:24 p.m.
Not sure why this change was made? Best to limit code changes in a patch to those that are about …	chipx86	Feb. 13, 2012, 8:26 p.m.
Blank line before this.	chipx86	Feb. 13, 2012, 8:24 p.m.

reviewboard/reviews/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Maybe "/changes" instead of "/changedescs".
```

reviewboard/reviews/views.py (Diff revision 1)

The issue has been resolved. Show all issues

Not sure why this change was made? Best to limit code changes in a patch to those that are about your task.

ammok Feb. 13, 2012, 8:26 p.m.

I was just applying the boy scout rule and adding an extra space to help it conform to PEP8.

chipx86 Feb. 14, 2012, 4:49 p.m.

Some things like that we're a bit less strict about. In general, though, while code cleanup is great, it's best left to its own change, unless you're dealing with code that's basically right in that territory. Keeps diffs smaller and makes it easier to see what's actually affected by what.

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line before this.
```

Diff:

Revision 2 (+17 -7)

Show changes

	reviewboard/reviews/urls.py
	reviewboard/reviews/views.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (293ac09)