Added a preview email page for changedescs.

Review Request #2858 — Created Feb. 11, 2012 and submitted

ammok
Review Board
reviewboard
Added a preview email page for changedescs.

This page takes the form of: http://{fqdn}/r/{review_request_id}/changedescs/{changedesc_id}/preview-email/{html|text}/
Local User Testing done on Linux 3.2.4 using Chromium 17.0.963.46
Description From Last Updated

Maybe "/changes" instead of "/changedescs".

chipx86chipx86

Not sure why this change was made? Best to limit code changes in a patch to those that are about ...

chipx86chipx86

Blank line before this.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/reviews/urls.py (Diff revision 1)
     
     
    Maybe "/changes" instead of "/changedescs".
  3. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Not sure why this change was made? Best to limit code changes in a patch to those that are about your task.
    1. I was just applying the boy scout rule and adding an extra space to help it conform to PEP8.
    2. Some things like that we're a bit less strict about. In general, though, while code cleanup is great, it's best left to its own change, unless you're dealing with code that's basically right in that territory. Keeps diffs smaller and makes it easier to see what's actually affected by what.
  4. reviewboard/reviews/views.py (Diff revision 1)
     
     
    Blank line before this.
  5. 
      
AM
chipx86
  1. Ship It!
  2. 
      
AM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (293ac09)
Loading...