-
-
reviewboard/scmtools/tests.py (Diff revision 1) Trying to move the tests to be in lowercase with underscores. I know it's inconsistent with the other ones in this class, but can this be test_encoding?
-
Enable passing through encoding to perforce tool.
Review Request #2832 — Created Jan. 29, 2012 and submitted
Enable passing through encoding to perforce tool. I believe perforce is utf8 by default, but some users want other encodings (such as utf16, shiftjis, etc). This change enables passing through the encoding to the perforce tool. I've added a unit test, which at the moment isn't as complete as I'd like because public.perforce.com doesn't have "unicode" turned on. It at least tests that we pass the parameter through to the underlying API/p4 binary, and fails with a useful message should they update the server.
Ran perforce tests.
Change Summary:
Made requested changes, plus fixed formatting of all the other test names so I didn't feel bad.
Diff: |
Revision 2 (+109 -80) |
|---|