Enable passing through encoding to perforce tool.

Review Request #2832 — Created Jan. 29, 2012 and submitted

david
Review Board
master
1735
reviewboard
Enable passing through encoding to perforce tool.

I believe perforce is utf8 by default, but some users want other encodings (such
as utf16, shiftjis, etc). This change enables passing through the encoding to
the perforce tool.

I've added a unit test, which at the moment isn't as complete as I'd like
because public.perforce.com doesn't have "unicode" turned on. It at least tests
that we pass the parameter through to the underlying API/p4 binary, and fails
with a useful message should they update the server.
Ran perforce tests.
Description From Last Updated

Trying to move the tests to be in lowercase with underscores. I know it's inconsistent with the other ones in …

chipx86chipx86

Indentation looks wrong.

chipx86chipx86
chipx86
  1. 
      
  2. reviewboard/scmtools/tests.py (Diff revision 1)
     
     
    Trying to move the tests to be in lowercase with underscores. I know it's inconsistent with the other ones in this class, but can this be test_encoding?
  3. reviewboard/scmtools/tests.py (Diff revision 1)
     
     
     
    Indentation looks wrong.
  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (5ed25c2).
Loading...