Summary

Enable passing through encoding to perforce tool.

Review Request #2832 — Created Jan. 29, 2012 and submitted Feb. 5, 2012, 2:38 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

1735

Depends On

Reviewers

Groups

reviewboard

People

Description

Enable passing through encoding to perforce tool.

I believe perforce is utf8 by default, but some users want other encodings (such
as utf16, shiftjis, etc). This change enables passing through the encoding to
the perforce tool.

I've added a unit test, which at the moment isn't as complete as I'd like
because public.perforce.com doesn't have "unicode" turned on. It at least tests
that we pass the parameter through to the underlying API/p4 binary, and fails
with a useful message should they update the server.

Testing Done

Ran perforce tests.

Issues

Description	From	Last Updated
Trying to move the tests to be in lowercase with underscores. I know it's inconsistent with the other ones in …	chipx86	Jan. 31, 2012, 5:53 a.m.
Indentation looks wrong.	chipx86	Jan. 31, 2012, 5:53 a.m.

reviewboard/scmtools/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

Trying to move the tests to be in lowercase with underscores. I know it's inconsistent with the other ones in this class, but can this be test_encoding?

reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Indentation looks wrong.
```

Change Summary:

Made requested changes, plus fixed formatting of all the other test names so I didn't feel bad.

Diff:

Revision 2 (+109 -80)

Show changes

	reviewboard/scmtools/perforce.py
	reviewboard/scmtools/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (5ed25c2).