Change Summary:
I'm not sure if there is a way to reference files in the contrib directory from the package.
Description: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+407) |
Created a new script for generating scaffolding for new extensions.
Review Request #2830 — Created Jan. 28, 2012 and submitted
Created a new script for generating scaffolding for new extensions. Previous code review: http://reviews.reviewboard.org/r/2822/
I added some unit tests for naming convention testing and conversion, but otherwise all testing has been manual on Linux 3.1.8-1. I have tried creating new extensions with each option, and installing the egg using easy_install name develop on a local environment.
| Description | From | Last Updated |
|---|---|---|
|
change option name to --package-name. |
BA bartek | |
|
The dashboard_link variable appears to be bool. If so, add action='store_true'. |
BA bartek | |
|
contrib/tools/templates/extensions/extension/extension.py:28:1: E112 expected an indented block |
CI cim1 | |
|
contrib/tools/templates/extensions/extension/extension.py:38:1: W391 blank line at end of file |
CI cim1 | |
|
contrib/tools/templates/extensions/extension/views.py:14:1: W391 blank line at end of file |
CI cim1 | |
|
contrib/tools/templates/extensions/setup.py:26:1: W391 blank line at end of file |
CI cim1 | |
|
I don't think this should go here as AFAIK contrib scripts are not installed so the dependency does not make … |
BA bartek |
AM
BA
-
-
contrib/tools/generate_extension.py (Diff revision 2) The dashboard_link variable appears to be bool. If so, add action='store_true'.
-
setup.py (Diff revision 2) I don't think this should go here as AFAIK contrib scripts are not installed so the dependency does not make sense
CI
-
Ran your code through PEP8.
-
contrib/tools/templates/extensions/extension/extension.py (Diff revision 2) contrib/tools/templates/extensions/extension/extension.py:28:1: E112 expected an indented block
-
contrib/tools/templates/extensions/extension/extension.py (Diff revision 2) contrib/tools/templates/extensions/extension/extension.py:38:1: W391 blank line at end of file
-
contrib/tools/templates/extensions/extension/views.py (Diff revision 2) contrib/tools/templates/extensions/extension/views.py:14:1: W391 blank line at end of file
-
contrib/tools/templates/extensions/setup.py (Diff revision 2) contrib/tools/templates/extensions/setup.py:26:1: W391 blank line at end of file
AM
