Summary

Created a new script for generating scaffolding for new extensions.

Review Request #2830 — Created Jan. 28, 2012 and submitted Feb. 25, 2012, 8:04 a.m.

Information

Owner

ammok

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Created a new script for generating scaffolding for new extensions.

Previous code review: http://reviews.reviewboard.org/r/2822/

Testing Done

I added some unit tests for naming convention testing and conversion, but otherwise all testing has been manual on Linux 3.1.8-1.
I have tried creating new extensions with each option, and installing the egg using easy_install name develop on a local environment.

Issues

Description	From	Last Updated
change option name to --package-name.	BA bartek	Feb. 1, 2012, 5:50 a.m.
The dashboard_link variable appears to be bool. If so, add action='store_true'.	BA bartek	Feb. 1, 2012, 5:50 a.m.
contrib/tools/templates/extensions/extension/extension.py:28:1: E112 expected an indented block	CI cim1	Feb. 1, 2012, 5:50 a.m.
contrib/tools/templates/extensions/extension/extension.py:38:1: W391 blank line at end of file	CI cim1	Feb. 1, 2012, 5:50 a.m.
contrib/tools/templates/extensions/extension/views.py:14:1: W391 blank line at end of file	CI cim1	Feb. 1, 2012, 5:50 a.m.
contrib/tools/templates/extensions/setup.py:26:1: W391 blank line at end of file	CI cim1	Feb. 1, 2012, 5:50 a.m.
I don't think this should go here as AFAIK contrib scripts are not installed so the dependency does not make …	BA bartek	Feb. 1, 2012, 5:50 a.m.

Change Summary:

I'm not sure if there is a way to reference files in the contrib directory from the package.

Description:

		Created a new script for generating scaffolding for new extensions.
	+
	+	Previous code review: http://reviews.reviewboard.org/r/2822/

Diff:

Revision 2 (+407)

Show changes

	setup.py
	contrib/tools/generate_extension.py
	contrib/tools/tests.py
	contrib/tools/templates/extensions/setup.py
	contrib/tools/templates/extensions/extension/__init__.py
	contrib/tools/templates/extensions/extension/admin_urls.py
	contrib/tools/templates/extensions/extension/extension.py
	contrib/tools/templates/extensions/extension/urls.py
	3 more

contrib/tools/generate_extension.py (Diff revision 2)

The issue has been resolved. Show all issues

The dashboard_link variable appears to be bool. If so, add action='store_true'.

ammok Jan. 31, 2012, 9:03 p.m.

I should change the help description to make it more clear, but this lets you set the name of the dashboard link which will indicate to the script that it should create the link.

bartek Jan. 31, 2012, 9:22 p.m.

Ah, missed it in template somehow. You can add 'metavar="LABEL"' in that case, which should be readable enough.

setup.py (Diff revision 2)

The issue has been resolved. Show all issues

I don't think this should go here as AFAIK contrib scripts are not installed so the dependency does not make sense

```
Ran your code through PEP8.
```

contrib/tools/templates/extensions/extension/extension.py (Diff revision 2)

The issue has been dropped. Show all issues

contrib/tools/templates/extensions/extension/extension.py:28:1: E112 expected an indented block

ammok Feb. 1, 2012, 5:46 a.m.

Since these aren't exactly python scripts, but rather templates, I thought that doing proper indentation with the template blocks would make it difficult to generate proper python files.

contrib/tools/templates/extensions/extension/extension.py (Diff revision 2)

The issue has been dropped. Show all issues

contrib/tools/templates/extensions/extension/extension.py:38:1: W391 blank line at end of file

ammok Feb. 1, 2012, 5:46 a.m.

I added this to counteract the W292 (no newline at end of file) on the generated files as Jinja2 automatically removes one newline.

contrib/tools/templates/extensions/extension/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
contrib/tools/templates/extensions/extension/views.py:14:1: W391 blank line at end of file
```
contrib/tools/templates/extensions/setup.py (Diff revision 2)
The issue has been dropped. Show all issues
```
contrib/tools/templates/extensions/setup.py:26:1: W391 blank line at end of file
```

contrib/tools/generate_extension.py (Diff revision 2)
The issue has been resolved. Show all issues
```
change option name to --package-name.
```

Diff:

Revision 3 (+410)

Show changes

	contrib/tools/generate_extension.py
	contrib/tools/tests.py
	contrib/tools/templates/extensions/setup.py
	contrib/tools/templates/extensions/extension/__init__.py
	contrib/tools/templates/extensions/extension/admin_urls.py
	contrib/tools/templates/extensions/extension/extension.py
	contrib/tools/templates/extensions/extension/urls.py
	contrib/tools/templates/extensions/extension/views.py
	2 more

Ship it!

This looks good to me - thanks Anthony!

-Mike

Status:: Completed
Change Summary:: Landed as 8d4e68c072. Thanks!