Added password reentry and verification in rb-site install

Review Request #2818 — Created Jan. 22, 2012 and submitted

weilul
Review Board
1631
reviewboard
There are two passwords prompts when installing a new site. One for the database, one for the admin user.

For the database: created variable "reenter_db_pass" in class "site", and added prompt input "Re=enter Database Password" to the screen; for the admin user: "reenter_admin_password", and "Re-enter Password".

Generally, created function "compare_var" in class "GtkUI" to check if the password matches its reentry; added the return value of the function to the variable "page[validators]".

In installation, the "next" button is disabled until the password matches its reentry.
Successfully tested on my ubuntu(virtual box)

Description From Last Updated

A slightly better option is this: if not save_var.startswith('reenter'):

daviddavid

This function name isn't very good. How about "confirm_reentry"?

daviddavid

Can you change this to "Confirm Database Password"?

daviddavid

"Confirm Password"

daviddavid

Don't add this line.

daviddavid
david
  1. 
      
  2. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    A slightly better option is this:
    if not save_var.startswith('reenter'):
  3. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    This function name isn't very good. How about "confirm_reentry"?
  4. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Can you change this to "Confirm Database Password"?
  5. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    "Confirm Password"
  6. reviewboard/cmdline/rbsite.py (Diff revision 1)
     
     
    Don't add this line.
  7. 
      
WE
david
  1. Ship It!
  2. 
      
WE
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (7b42518). Thanks!
Loading...