Fix UnicodeEncodeErrors when viewing the user infobox for users with unicode names

Review Request #2813 — Created Jan. 21, 2012 and submitted

david
Review Board
release-1.6.x
2309
reviewboard
Fix UnicodeEncodeErrors when viewing the user infobox for users with unicode names

When a user had unicode in their full name or email address, the infobox view
would crash with a UnicodeEncodeError, because etags can only contain ascii.
This fixes it to explicitly encode everything to ascii, replacing characters if
needed.
Ran newly-added test before and after the change.
Description From Last Updated

No need for the "response =". It'll just upset pyflakes. Unless you want to check the contents?

chipx86chipx86
david
chipx86
  1. 
      
  2. reviewboard/reviews/tests.py (Diff revision 1)
     
     
     
    No need for the "response =". It'll just upset pyflakes. Unless you want to check the contents?
  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-1.6.x (731c0f6).
Loading...