Summary

Fix UnicodeEncodeErrors when viewing the user infobox for users with unicode names

Review Request #2813 — Created Jan. 21, 2012 and submitted Jan. 23, 2012, 3:34 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-1.6.x

Bugs

2309

Depends On

Reviewers

Groups

reviewboard

People

Description

Fix UnicodeEncodeErrors when viewing the user infobox for users with unicode names

When a user had unicode in their full name or email address, the infobox view
would crash with a UnicodeEncodeError, because etags can only contain ascii.
This fixes it to explicitly encode everything to ascii, replacing characters if
needed.

Testing Done

Ran newly-added test before and after the change.

Issues

Description	From	Last Updated
No need for the "response =". It'll just upset pyflakes. Unless you want to check the contents?	chipx86	Jan. 23, 2012, 3:36 p.m.

Change Summary:: I found a duplicate bug.
Bugs:: 2377
2309

reviewboard/reviews/tests.py (Diff revision 1)

The issue has been resolved. Show all issues

No need for the "response =". It'll just upset pyflakes. Unless you want to check the contents?

Status:: Completed
Change Summary:: Pushed to release-1.6.x (731c0f6).