-
-
reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 1) I feel like this should be collapsed into a single function, but can't think of a good way to do it. The javascript might be simpler if you used hiding instead of modifying the html. Although, that would just be creating repetition in the html instead...
Added Collapse All button
Review Request #2808 — Created Jan. 21, 2012 and submitted
Information | |
---|---|
medanat | |
Review Board | |
Reviewers | |
reviewboard | |
Added permanent Collapse All button instead of a dynamic toggle.
Local machine: Ubuntu/Chromium.
Description | From | Last Updated |
---|---|---|
I think we're going to be putting the issue summary table into the details box above the series of review … |
|
|
Just curious - why aren't we using the alt attributes? |
|
SM
ME
Change Summary:
Added permanent Collapse All button instead of a dynamic toggle.
Summary: |
|
||||||
---|---|---|---|---|---|---|---|
Description: |
|
||||||
Diff: |
Revision 2 (+19 -4) |
-
Yazan: This looks good. Good work. Two questions. Once resolved...I think you've got my ship-it. -Mike
-
reviewboard/htdocs/media/rb/js/reviews.js (Diff revision 2) I think we're going to be putting the issue summary table into the details box above the series of review boxes...so I'm not sure this will apply...
-
reviewboard/templates/reviews/review_detail.html (Diff revision 2) Just curious - why aren't we using the alt attributes?