Added a "To Me" column to the pages with lists of Reviews.
Review Request #2802 — Created Jan. 20, 2012 and submitted
| Information | |
|---|---|
| ammok | |
| Review Board | |
| 495 | |
| Reviewers | |
| reviewboard | |
Addresses issue 495. Added a "To Me" column to the pages with lists of Reviews, and the requests that target a logged-in user will be indicated with a ».
Tested on local dev environment on Linux using Chromium 16.0.912.75.
| Description | From | Last Updated |
|---|---|---|
|
Two blank lines (to follow PEP8) |
DD ddruska | |
|
How about label being » as well? |
 david
|
|
|
You can use .exists() here instead of count: https://docs.djangoproject.com/en/dev/ref/models/querysets/#exists |
DD ddruska | |
|
Two blank lines here too! |
DD ddruska | |
|
At least two spaces before inline comment |
DD ddruska |
DD
-
-
-
reviewboard/reviews/datagrids.py (Diff revision 1) You can use .exists() here instead of count: https://docs.djangoproject.com/en/dev/ref/models/querysets/#exists
-
AM
Change Summary:
In addition to addressing the changes, I have added » to the detailed label to make it more in line with the icon-based columns.
Diff: |
Revision 2 (+22) |
|---|
DD
-
Run pep8 before posting reviews ("pip install pep8" if you don't have it) -
AM
Change Summary:
Added the extra space and an extra line further down where it was violating PEP 8.
Diff: |
Revision 3 (+23) |
|---|