Added a "To Me" column to the pages with lists of Reviews.

Review Request #2802 — Created Jan. 20, 2012 and submitted

Information

Review Board
495

Reviewers

Addresses issue 495.

Added a "To Me" column to the pages with lists of Reviews, and the requests that target a logged-in user will be indicated with a ».
Tested on local dev environment on Linux using Chromium 16.0.912.75.
Description From Last Updated

Two blank lines (to follow PEP8)

DD ddruska

How about label being » as well?

daviddavid

You can use .exists() here instead of count: https://docs.djangoproject.com/en/dev/ref/models/querysets/#exists

DD ddruska

Two blank lines here too!

DD ddruska

At least two spaces before inline comment

DD ddruska
david
  1. Can you add a screenshot?
  2. 
      
AM
DD
  1. 
      
  2. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
     
    Two blank lines (to follow PEP8)
  3. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    You can use .exists() here instead of count: https://docs.djangoproject.com/en/dev/ref/models/querysets/#exists
  4. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
     
    Two blank lines here too!
  5. 
      
david
  1. 
      
  2. reviewboard/reviews/datagrids.py (Diff revision 1)
     
     
    How about label being » as well?
    1. Since the template is set up to escape the characters in label and detailed_label, I have opted to use the unicode character corresponding to »
  3. 
      
AM
DD
  1. Run pep8 before posting reviews ("pip install pep8" if you don't have it)
  2. reviewboard/reviews/datagrids.py (Diff revision 2)
     
     
    At least two spaces before inline comment
  3. 
      
AM
david
  1. Before I submit this, can I see an updated screenshot?
  2. 
      
AM
david
  1. Ship It!
  2. 
      
AM
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (08c2af6). Thanks!
Loading...