Summary

Added a "To Me" column to the pages with lists of Reviews.

Review Request #2802 — Created Jan. 20, 2012 and submitted Jan. 21, 2012, 7:22 a.m.

Information

Owner

ammok

Repository

Review Board

Branch

Bugs

495

Depends On

Reviewers

Groups

reviewboard

People

Description

Addresses issue 495.

Added a "To Me" column to the pages with lists of Reviews, and the requests that target a logged-in user will be indicated with a &raquo;.

Testing Done

Tested on local dev environment on Linux using Chromium 16.0.912.75.

Screenshots

To Me column in Action

Updated To Me column

Issues

Description	From	Last Updated
Two blank lines (to follow PEP8)	DD ddruska	Jan. 21, 2012, 2:26 a.m.
How about label being » as well?	david	Jan. 20, 2012, 8:57 a.m.
You can use .exists() here instead of count: https://docs.djangoproject.com/en/dev/ref/models/querysets/#exists	DD ddruska	Jan. 21, 2012, 2:26 a.m.
Two blank lines here too!	DD ddruska	Jan. 21, 2012, 2:26 a.m.
At least two spaces before inline comment	DD ddruska	Jan. 21, 2012, 2:33 a.m.

```
Can you add a screenshot?
```

Screenshots:

+	To Me column in Action

reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Two blank lines (to follow PEP8)
```

reviewboard/reviews/datagrids.py (Diff revision 1)

The issue has been resolved. Show all issues

You can use .exists() here instead of count: https://docs.djangoproject.com/en/dev/ref/models/querysets/#exists

reviewboard/reviews/datagrids.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Two blank lines here too!
```

Fix it!

reviewboard/reviews/datagrids.py (Diff revision 1)

An issue was opened. Show all issues

How about label being &raquo; as well?

ammok Jan. 21, 2012, 2:13 a.m.

Since the template is set up to escape the characters in label and detailed_label, I have opted to use the unicode character corresponding to &raquo;

Change Summary:

In addition to addressing the changes, I have added &raquo; to the detailed label to make it more in line with the icon-based columns.

Diff:

Revision 2 (+22)

Show changes

reviewboard/reviews/datagrids.py

Run pep8 before posting reviews ("pip install pep8" if you don't have it)

reviewboard/reviews/datagrids.py (Diff revision 2)
The issue has been resolved. Show all issues
```
At least two spaces before inline comment
```

Change Summary:

Added the extra space and an extra line further down where it was violating PEP 8.

Diff:

Revision 3 (+23)

Show changes

reviewboard/reviews/datagrids.py

Before I submit this, can I see an updated screenshot?

Screenshots:

+	Updated To Me column

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (08c2af6). Thanks!