Make "Expand All" icon work in review request page

Review Request #2801 — Created Jan. 20, 2012 and submitted

smacleod
Review Board
2439
reviewboard
Fixed issue 2439.

The "+" icon to "Expand All" reviews on the review request page is now click-able.
Tested on local dev using Chrome 16.0.912.75
Description From Last Updated

Great job! One issue though: element id's should be unique, i.e. no two elements can have the same id. In ...

ME medanat
DD
  1. Ship It!
  2. 
      
ME
  1. 
      
  2. Great job! One issue though: element id's should be unique, i.e. no two elements can have the same id. 
    
    In this case I suggest wrapping the img element and the {% trans "Expand All" %} within the same anchor (<a> element).
    
    For future reference, when multiple elements wish to share a reference, use the class attribute.
  3. 
      
SM
david
  1. Looks good! I'll handle pushing this.
  2. 
      
SM
Review request changed

Status: Closed (submitted)

Change Summary:

Fixed in master (df73fcc).
Loading...