Fixed "Posted" date appears in the dashboard, but not in the review

Review Request #2800 — Created Jan. 20, 2012 and submitted

Information

Review Board

Reviewers

Fixed issue 1252 by adding a "created" date before the last updated time since.
Local testing, 3 line change.

Screenshots

Description From Last Updated

You can replace the white space with   to avoid the white space complaint.

ME medanat

You can't just concatenate sentences together like this if we want to be future-proof for translation. In fact, the way …

daviddavid
ME
  1. 
      
  2. Show all issues
    You can replace the white space with   to avoid the white space complaint.
  3. 
      
CI
david
  1. 
      
  2. reviewboard/templates/reviews/review_request_box.html (Diff revision 2)
     
     
     
     
     
     
     
     
    Show all issues
    You can't just concatenate sentences together like this if we want to be future-proof for translation. In fact, the way we were doing it before is also broken.
    
    Ideally we'd have something like this:
    {% ifequal review_request.status 'S' %}
      {% blocktrans with ... %}
        Created {{dateadded}} and submitted {{lastupdated}} ago.
      {% endblocktrans %}
    {% endifequal %}
    {% ifequal ...
    
    
    That way, each entire sentence is wrapped in blocktrans, and can be translated as a unit.
  3. 
      
CI
david
  1. Ship It!
  2. 
      
CI
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (8069c1d). Thanks!
Loading...