Summary

Fix SPF Compliance

Review Request #2702 — Created Nov. 11, 2011 and submitted Dec. 1, 2011, 3:37 p.m.

Information

Owner

bcooksley

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Currently Reviewboard sends emails with a Return-Path of the current user. This is not SPF compliant, and as a result review emails will be rejected if a user's domain implements SPF with a reject all failed messages policy and a reciever checks SPF.

This corrects this by setting the From header directly instead, and passing the site default from email address as the Return-Path address.
This is needed on the KDE Reviewboard instance to ensure email delivery runs well.

Testing Done

Local development 1.6.x instance. From header is still set correctly, whilst Return-Path is now SPF compliant.

Seems good

bcooksley Nov. 20, 2011, 1:43 p.m.

Can someone please commit this for me, I have no commit access. I should note I recieved no email for the above review.

bcooksley Nov. 27, 2011, 4:10 p.m.

What is the status of this being committed to Reviewboard's codebase?

chipx86 Dec. 1, 2011, 3:30 p.m.

It needed a review by one of the core devs, and we've been out.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-1.6.x (648eeaa)