Add post-review option for specifying basedir

Review Request #2693 — Created Nov. 8, 2011 and discarded

Information

RBTools

Reviewers

I was having an issue when attempting to upload "svn diff" generated diffs with post-review. It was not properly detecting the basedir so I added the ability to override the autodetection by specifying --basedir=
With an SVN repository:
if --basedir=Directory is not specified or is blank autodetection still kicks in.
if it is specified then the specified basedir is sent with the diff upload.
Description From Last Updated

We should only use --basedir in the case where we're also using --diff-filename It doesn't make sense in the case …

daviddavid
MI
  1. This works perfectly for me.  With this patch, I can actually submit SVN diff files to ReviewBoard - something I was unable to do before.  Thanks!
  2. 
      
david
  1. 
      
  2. rbtools/postreview.py (Diff revision 1)
     
     
     
    We should only use --basedir in the case where we're also using --diff-filename
    
    It doesn't make sense in the case where post-review is creating the diff itself
  3. 
      
NH
Review request changed

Status: Discarded

Loading...