Summary

Add post-review option for specifying basedir

Review Request #2693 — Created Nov. 8, 2011 and discarded July 5, 2013, 4:31 p.m.

Information

Owner

nhorvath

Repository

RBTools

Branch

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

I was having an issue when attempting to upload "svn diff" generated diffs with post-review. It was not properly detecting the basedir so I added the ability to override the autodetection by specifying --basedir=

Testing Done

With an SVN repository:
if --basedir=Directory is not specified or is blank autodetection still kicks in.
if it is specified then the specified basedir is sent with the diff upload.

Issues

Description	From	Last Updated
We should only use --basedir in the case where we're also using --diff-filename It doesn't make sense in the case …	david	July 15, 2012, 1:13 p.m.

This works perfectly for me.  With this patch, I can actually submit SVN diff files to ReviewBoard - something I was unable to do before.  Thanks!

Fix it!

rbtools/postreview.py (Diff revision 1)

An issue was opened. Show all issues

We should only use --basedir in the case where we're also using --diff-filename

It doesn't make sense in the case where post-review is creating the diff itself

Status:: Discarded