Move our stylesheets to lessCSS.

Review Request #2658 — Created Oct. 14, 2011 and submitted

Information

Review Board

Reviewers

Move our stylesheets to lessCSS.

This updates all of our stylesheets to be .less files. In the process,
I've cleaned up most of the rules to add some structure and, in some
cases, added definitions for colors and other values.

There's still a long ways to go here, but it's a good start and
definitely makes things more manageable.

Where it made sense, I renamed some classes in the HTML to make things
more clear and organized.

This will work perfectly fine on production installs or developer installs.
Went through the site and checked to see if anything looked broken.

I checked the My Account page, Dashboard, Log In, review requests,
diffs, screenshots, and all the parts of the admin UI. I didn't see
anything stand out as obviously broken. I'm sure we'll hit something small
here and there.
Description From Last Updated

For things with IDs like this, we shouldn't necessarily nest them. The selectors that end up getting generated aren't as …

daviddavid

Can you indent the first *s one space to make alignment prettier?

daviddavid

Same here with IDs nested inside a class

daviddavid

There's a whole lot of colors included directly in rules here. Should variables be defined for them?

daviddavid

This isn't indented correctly.

daviddavid

Same here re: indent.

daviddavid

Should this have the full multi-line comment? /************** * Dashboard **************/

daviddavid

One blank line

daviddavid

Blank line

daviddavid
david
  1. 
      
  2. For things with IDs like this, we shouldn't necessarily nest them. The selectors that end up getting generated aren't as efficient as they should be.
    1. Sure. Ideally this would happen during minification, because it's nice to be able to keep the structure the same for organization purposes, but yeah..
    2. Actually, it's less simple than that. There are multiple pages using the same IDs but in different contexts, so the nested selectors are important.
      
      I'm sure there are some we can remove, but it'd require a lot of analysis of our rules, andtemplates, and Django's. Mind if I keep it as it is for now and do another pass later?
    3. Of course.
  3. reviewboard/htdocs/media/rb/css/admin.less (Diff revision 1)
     
     
     
     
    Can you indent the first *s one space to make alignment prettier?
    1. Sure. Copied/pasted from the original.
  4. Same here with IDs nested inside a class
  5. There's a whole lot of colors included directly in rules here. Should variables be defined for them?
    1. Yeah, I plan to make another pass through, but I wanted to get something in to test with sooner rather than later and was kind of tired of updating :)
  6. This isn't indented correctly.
    1. Will go through and ensure all indentation is correct.
  7. reviewboard/htdocs/media/rb/css/common.less (Diff revision 1)
     
     
     
     
     
     
     
     
    Same here re: indent.
  8. 
      
chipx86
david
  1. Just some trivial stuff.
  2. Should this have the full multi-line comment?
    
    /**************
     * Dashboard
     **************/
  3. One blank line
  4. Blank line
  5. Same here and more.
  6. 
      
chipx86
Review request changed

Status: Closed (submitted)

Loading...