Summary

Move our stylesheets to lessCSS.

Review Request #2658 — Created Oct. 14, 2011 and submitted Nov. 6, 2011, 4:09 a.m.

Information

Owner

Repository

Review Board

Branch

Bugs

Depends On

Reviewers

Groups

People

Description

Move our stylesheets to lessCSS.

This updates all of our stylesheets to be .less files. In the process,
I've cleaned up most of the rules to add some structure and, in some
cases, added definitions for colors and other values.

There's still a long ways to go here, but it's a good start and
definitely makes things more manageable.

Where it made sense, I renamed some classes in the HTML to make things
more clear and organized.

This will work perfectly fine on production installs or developer installs.

Testing Done

Went through the site and checked to see if anything looked broken.

I checked the My Account page, Dashboard, Log In, review requests,
diffs, screenshots, and all the parts of the admin UI. I didn't see
anything stand out as obviously broken. I'm sure we'll hit something small
here and there.

Issues

Description	From	Last Updated
For things with IDs like this, we shouldn't necessarily nest them. The selectors that end up getting generated aren't as …	david	Oct. 15, 2011, 8:35 a.m.
Can you indent the first *s one space to make alignment prettier?	david	Oct. 15, 2011, 6:27 p.m.
Same here with IDs nested inside a class	david	Oct. 15, 2011, 8:35 a.m.
There's a whole lot of colors included directly in rules here. Should variables be defined for them?	david	Oct. 15, 2011, 8:35 a.m.
This isn't indented correctly.	david	Oct. 15, 2011, 6:28 p.m.
Same here re: indent.	david	Oct. 15, 2011, 6:28 p.m.
Should this have the full multi-line comment? /************** * Dashboard **************/	david	Oct. 16, 2011, 3:34 p.m.
One blank line	david	Oct. 16, 2011, 3:34 p.m.
Blank line	david	Oct. 16, 2011, 3:34 p.m.

Fix it!

reviewboard/htdocs/media/rb/css/admin.less (Diff revision 1)

An issue was opened. Show all issues

For things with IDs like this, we shouldn't necessarily nest them. The selectors that end up getting generated aren't as efficient as they should be.

Oct. 15, 2011, 6:13 p.m.

Sure. Ideally this would happen during minification, because it's nice to be able to keep the structure the same for organization purposes, but yeah..

Oct. 15, 2011, 6:28 p.m.

Actually, it's less simple than that. There are multiple pages using the same IDs but in different contexts, so the nested selectors are important.

I'm sure there are some we can remove, but it'd require a lot of analysis of our rules, andtemplates, and Django's. Mind if I keep it as it is for now and do another pass later?

david

Oct. 16, 2011, 3:29 p.m.
```
Of course.
```

reviewboard/htdocs/media/rb/css/admin.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you indent the first *s one space to make alignment prettier?
```
1. chipx86
  
  Oct. 15, 2011, 6:13 p.m.
  Sure. Copied/pasted from the original.
reviewboard/htdocs/media/rb/css/admin.less (Diff revision 1)
An issue was opened. Show all issues
```
Same here with IDs nested inside a class
```

reviewboard/htdocs/media/rb/css/common.less (Diff revision 1)

An issue was opened. Show all issues

There's a whole lot of colors included directly in rules here. Should variables be defined for them?

Oct. 15, 2011, 6:13 p.m.

Yeah, I plan to make another pass through, but I wanted to get something in to test with sooner rather than later and was kind of tired of updating :)

reviewboard/htdocs/media/rb/css/common.less (Diff revision 1)
The issue has been resolved. Show all issues
```
This isn't indented correctly.
```
1. chipx86
  
  Oct. 15, 2011, 6:13 p.m.
  Will go through and ensure all indentation is correct.

reviewboard/htdocs/media/rb/css/common.less (Diff revision 1)

The issue has been resolved. Show all issues

Same here re: indent.

Change Summary:

* Synced with the new settings and admin changes.
* Fixed indentation.
* Fixed a section comment.

Diff:

Revision 2 (+3413 -3417)

	reviewboard/settings.py
	reviewboard/htdocs/media/rb/css/admin.css
	reviewboard/htdocs/media/rb/css/admin.less
	reviewboard/htdocs/media/rb/css/admin-dashboard.css
	reviewboard/htdocs/media/rb/css/admin-dashboard.less
	reviewboard/htdocs/media/rb/css/common.css
	reviewboard/htdocs/media/rb/css/common.less
	reviewboard/htdocs/media/rb/css/dashboard.css
	19 more

Ship it! Fix it!

```
Just some trivial stuff.
```

reviewboard/htdocs/media/rb/css/admin.less (Diff revision 2)

An issue was opened. Show all issues

Should this have the full multi-line comment?

/**************
 * Dashboard
 **************/

reviewboard/htdocs/media/rb/css/reviews.less (Diff revision 2)
An issue was opened. Show all issues
```
One blank line
```
reviewboard/htdocs/media/rb/css/reviews.less (Diff revision 2)
An issue was opened. Show all issues
```
Blank line
```
reviewboard/htdocs/media/rb/css/reviews.less (Diff revision 2)
```
Same here and more.
```

Status:: Completed