Summary:

add support for pagination in the diff viewer

Review Request #265 — Created Feb. 20, 2008 and submitted

Information
Owner:	timsub1
Repository:	Review Board SVN (deprecated)
Branch:
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

I took a crack at adding pagination to the diff viewer.  The problem I'm trying to solve is that, when the diffs are too big, the browser has trouble displaying them.  There is a typical list of page numbers and previous/next links.  The code is based on the paginator stuff I saw on the Django website.  I also modified the links in the threaded comment view to include the file id as a parameter, so we can flip to the right page.

Testing Done

david March 21, 2008, 3:54 p.m.

I've gone ahead and cleaned up most of this and committed it.  On more than
one occasion, a gigantic diff (>200 files changed) has taken down our server,
and I'm fed up with having 40 people tell me all at once that review board
is down :)

Christian says he'll take care of the djblets code-sharing later.  I'll
leave this review open to remind him.  Of course, anyone is welcome to do it
if they're quicker.

Thanks, Tim!

/trunk/reviewboard/diffviewer/views.py (Diff revision 1)

Can you put this in the list alphabetically (by module name)?

/trunk/reviewboard/diffviewer/views.py (Diff revision 1)

Each comment should be sentence case, and a blank line before each comment.

/trunk/reviewboard/diffviewer/views.py (Diff revision 1)

Blank line before and after each for loop.

/trunk/reviewboard/diffviewer/views.py (Diff revision 1)
```
Excess whitespace.
```
/trunk/reviewboard/diffviewer/views.py (Diff revision 1)
```
Sentence case.
```

/trunk/reviewboard/htdocs/css/diffviewer.css (Diff revision 1)

Can we reuse the CSS for the datagrids?

/trunk/reviewboard/settings.py (Diff revision 1)

Same with sentence case and blank lines.

Can you change these to DIFFVIEWER_PAGINATE_BY and DIFFVIEWER_PAGINATE_ORPHANS?

/trunk/reviewboard/templates/diffviewer/changeindex.html (Diff revision 1)

I think you can use the djblets.datagrid.templatetags.paginator tag for most of this.