-
-
/trunk/reviewboard/diffviewer/views.py (Diff revision 1) Can you put this in the list alphabetically (by module name)?
-
/trunk/reviewboard/diffviewer/views.py (Diff revision 1) Each comment should be sentence case, and a blank line before each comment.
-
-
-
-
/trunk/reviewboard/htdocs/css/diffviewer.css (Diff revision 1) Can we reuse the CSS for the datagrids?
-
/trunk/reviewboard/settings.py (Diff revision 1) Same with sentence case and blank lines. Can you change these to DIFFVIEWER_PAGINATE_BY and DIFFVIEWER_PAGINATE_ORPHANS?
-
/trunk/reviewboard/templates/diffviewer/changeindex.html (Diff revision 1) I think you can use the djblets.datagrid.templatetags.paginator tag for most of this.
add support for pagination in the diff viewer
Review Request #265 — Created Feb. 20, 2008 and submitted
Information | |
---|---|
timsub1 | |
Review Board SVN (deprecated) | |
Reviewers | |
reviewboard | |
I took a crack at adding pagination to the diff viewer. The problem I'm trying to solve is that, when the diffs are too big, the browser has trouble displaying them. There is a typical list of page numbers and previous/next links. The code is based on the paginator stuff I saw on the Django website. I also modified the links in the threaded comment view to include the file id as a parameter, so we can flip to the right page.