Allow adding custom Django apps in settings_local.py

Review Request #2630 — Created Sept. 29, 2011 and submitted

Information

Review Board
master

Reviewers

Allow adding custom Django apps in settings_local.py

This makes it easy to add per-site additional Django applications, such as custom auth processors. In order to add a new app, settings_local.py just has to provide the variable RB_EXTRA_APPS.
Tested successfully with django-socialregistration.

RB_EXTRA_APPS = (
    'socialregistration',
)
Description From Last Updated

I think this would be a lot cleaner if we split things up: RB_BUILTIN_APPS = [ 'django.contrib.admin', ... ] RB_EXTRA_APPS …

daviddavid
david
  1. 
      
  2. reviewboard/settings.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    Show all issues
    I think this would be a lot cleaner if we split things up:
    
    RB_BUILTIN_APPS = [
        'django.contrib.admin',
        ...
    ]
    
    RB_EXTRA_APPS = []
    
    try:
        import settings_local
    ...
    
    
    INSTALLED_APPS = RB_BUILTIN_APPS + RB_EXTRA_APPS + ['django_evolution']
  3. 
      
sgallagh
david
  1. Ship It!
  2. 
      
sgallagh
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (669262c)
Loading...