Summary

Allow adding custom Django apps in settings_local.py

Review Request #2630 — Created Sept. 29, 2011 and submitted Oct. 14, 2011, 3:23 a.m.

Information

Owner

sgallagh

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

chipx86

Description

Allow adding custom Django apps in settings_local.py

This makes it easy to add per-site additional Django applications, such as custom auth processors. In order to add a new app, settings_local.py just has to provide the variable RB_EXTRA_APPS.

Testing Done

Tested successfully with django-socialregistration.

RB_EXTRA_APPS = (
    'socialregistration',
)

Issues

Description	From	Last Updated
I think this would be a lot cleaner if we split things up: RB_BUILTIN_APPS = [ 'django.contrib.admin', ... ] RB_EXTRA_APPS …	david	Oct. 11, 2011, 3:13 a.m.

reviewboard/settings.py (Diff revision 1)

The issue has been resolved. Show all issues

I think this would be a lot cleaner if we split things up:

RB_BUILTIN_APPS = [
    'django.contrib.admin',
    ...
]

RB_EXTRA_APPS = []

try:
    import settings_local
...


INSTALLED_APPS = RB_BUILTIN_APPS + RB_EXTRA_APPS + ['django_evolution']

Change Summary:

The patch now creates RB_BUILTIN_APPS, RB_EXTRA_APPS and then concatenates them together with 'django_evolution' to produce INSTALLED_APPS.

Diff:

Revision 2 (+6 -3)

Show changes

reviewboard/settings.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (669262c)